Bug 68292 - Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
Summary: Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 68012
  Show dependency tree / graph
 
Reported: 2011-09-16 16:57 PDT by Adam Barth
Modified: 2011-09-19 15:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2011-09-16 16:59 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-09-16 16:57:34 PDT 
Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
Comment 1 Adam Barth 2011-09-16 16:59:21 PDT 
Created attachment 107748 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-09-16 17:58:15 PDT 
Comment on attachment 107748 [details]
Patch

Why USE?  Isn't this a feature?
Comment 3 Eric Seidel (no email) 2011-09-16 17:58:58 PDT 
Comment on attachment 107748 [details]
Patch

Do we have other sanitizers we can use?  What happens when this is disabled?
Comment 4 Adam Barth 2011-09-16 18:18:14 PDT 
> Why USE?  Isn't this a feature?

Nope.  It's just a library:

http://code.google.com/p/ots/

> Do we have other sanitizers we can use?  What happens when this is disabled?

Folks who don't use the sanitizer just use the fonts directly, which increases security risk.
Comment 5 Adam Barth 2011-09-19 15:53:49 PDT 
Comment on attachment 107748 [details]
Patch

Clearing flags on attachment: 107748

Committed r95487: <http://trac.webkit.org/changeset/95487>
Comment 6 Adam Barth 2011-09-19 15:53:52 PDT 
All reviewed patches have been landed.  Closing bug.