Bug 68765 – Remove ENABLE(FTPDIR) and associated code

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Adam Barth]

Remove ENABLE(FTPDIR) and associated code

[Adam Barth]

Created attachment 108588 [details]
Patch

[Mark Rowe (bdash)]

Why is this being removed given that it’s enabled and used by Safari on Windows?

[Adam Barth]

> Why is this being removed given that it’s enabled and used by Safari on Windows?

Perhaps I misunderstood Platform.h.  This block of code makes it look like it is enabled only for PLATFORM(IOS):

http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/Platform.h#L572

Can you show me how to tell it is enabled on PLATFORM(WIN) so that I can avoid this sort of mistake in the future?

[Mark Rowe (bdash)]

791	#if !defined(ENABLE_FTPDIR)
792	#define ENABLE_FTPDIR 1
793	#endif

[Adam Barth]

Thanks.  To be clear, are you asking for this code to be keep or just asking why I've posted this patch to remove it?

[Mark Rowe (bdash)]

Comment on attachment 108588 [details]
Patch

Please don’t remove code that other ports are actively using.

[Mark Rowe (bdash)]

Is that clearer?

[Adam Barth]

> Is that clearer?

Yes.  Thank you.

Please consider replying to this message on webkit-dev if there are other ENABLE macros slated for removal that you believe we should not remove:

http://www.mail-archive.com/[e-mail]/msg16428.html

Alternatively, please feel encouraged to comment on this document, which contains updates based on the webkit-dev discussion:

https://docs.google.com/document/d/1MVbOTYkZxTj071-ZQI7Lsh7CdZJhS2_1OdU4bjYuaKA/edit?hl=en_US

[Mark Rowe (bdash)]

Please consider double-checking your work before you propose deleting code that other people are using.

[Adam Barth]

> Please consider double-checking your work before you propose deleting code that other people are using.

As part of this process, we are removing code that other folks are using.  For example, there were even folks using WML before we removed it.  That's why these changes are being discussed on webkit-dev and in these bug threads before they happen.

In any case, my goal here is not to make any controversial changes.  Thanks for providing feedback at this stage of the process.  The earlier in the process that you're able to provide feedback, the more efficient it is for the project as a whole.