Bug 70189 - Always enable ENABLE(DOM_STORAGE)
Summary: Always enable ENABLE(DOM_STORAGE)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 68012
  Show dependency tree / graph
 
Reported: 2011-10-15 17:26 PDT by Adam Barth
Modified: 2011-10-16 03:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (107.17 KB, patch)
2011-10-15 17:28 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (107.17 KB, patch)
2011-10-15 17:50 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (109.18 KB, patch)
2011-10-15 18:28 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (110.45 KB, patch)
2011-10-15 20:59 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-10-15 17:26:24 PDT 
Always enable ENABLE(DOM_STORAGE)
Comment 1 Adam Barth 2011-10-15 17:28:43 PDT 
Created attachment 111156 [details]
Patch
Comment 2 Early Warning System Bot 2011-10-15 17:42:07 PDT 
Comment on attachment 111156 [details]
Patch

Attachment 111156 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10076370
Comment 3 Adam Barth 2011-10-15 17:50:01 PDT 
Created attachment 111158 [details]
Patch
Comment 4 Early Warning System Bot 2011-10-15 18:03:48 PDT 
Comment on attachment 111158 [details]
Patch

Attachment 111158 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10075359
Comment 5 Gyuyoung Kim 2011-10-15 18:24:58 PDT 
Comment on attachment 111158 [details]
Patch

Attachment 111158 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10078377
Comment 6 WebKit Review Bot 2011-10-15 18:27:49 PDT 
Comment on attachment 111158 [details]
Patch

Attachment 111158 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10079288
Comment 7 Adam Barth 2011-10-15 18:28:44 PDT 
Created attachment 111161 [details]
Patch
Comment 8 WebKit Review Bot 2011-10-15 19:32:57 PDT 
Comment on attachment 111161 [details]
Patch

Attachment 111161 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10077383

New failing tests:
storage/domstorage/sessionstorage/window-open.html
Comment 9 WebKit Review Bot 2011-10-15 20:28:13 PDT 
Comment on attachment 111161 [details]
Patch

Attachment 111161 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10073458

New failing tests:
storage/domstorage/sessionstorage/window-open.html
Comment 10 Adam Barth 2011-10-15 20:59:17 PDT 
Created attachment 111173 [details]
Patch
Comment 11 Eric Seidel (no email) 2011-10-16 02:04:20 PDT 
Comment on attachment 111173 [details]
Patch

SGTM.
Comment 12 WebKit Review Bot 2011-10-16 03:29:15 PDT 
Comment on attachment 111173 [details]
Patch

Clearing flags on attachment: 111173

Committed r97574: <http://trac.webkit.org/changeset/97574>
Comment 13 WebKit Review Bot 2011-10-16 03:29:20 PDT 
All reviewed patches have been landed.  Closing bug.