Bug 109588 – [Texmap] Implementation for pattern compositing

• Component: New Bugs
• Status: RESOLVED FIXED

[Noam Rosenthal]

[Texmap] Implementation for pattern compositing

[Noam Rosenthal]

Created attachment 187876 [details]
Patch

[Early Warning System Bot]

Comment on attachment 187876 [details]
Patch

Attachment 187876 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16510287

[Early Warning System Bot]

Comment on attachment 187876 [details]
Patch

Attachment 187876 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16517258

[EFL EWS Bot]

Comment on attachment 187876 [details]
Patch

Attachment 187876 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16531132

[Noam Rosenthal]

Created attachment 198125 [details]
Patch

[Allan Sandfeld Jensen]

Comment on attachment 198125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198125&action=review

Is this supposed to be always disabled, and what happens to TextureMapperImageBuffer in this case?

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:587
> +        layer->setShouldMapBackingStoreToContentsRect(false);

Isn't it always false?

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:594
> +//    layer->setShouldMapBackingStoreToContentsRect(true);

Is that supposed to be commented out?

[Noam Rosenthal]

Comment on attachment 198125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198125&action=review

>> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:587
>> +        layer->setShouldMapBackingStoreToContentsRect(false);
> 
> Isn't it always false?

See below

>> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:594
>> +//    layer->setShouldMapBackingStoreToContentsRect(true);
> 
> Is that supposed to be commented out?

No, it's a debugging leftover...

[Noam Rosenthal]

Created attachment 198850 [details]
Patch

[Allan Sandfeld Jensen]

Comment on attachment 198850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198850&action=review

LGTM

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:124
> +    if (m_state.solidColor.isValid() && !m_state.contentsRect.isEmpty() && m_state.solidColor.alpha()) {

Unrelated optimization, isn't it?

But I will let it slide.

[Noam Rosenthal]

(In reply to comment #9)
> (From update of attachment 198850 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198850&action=review
> 
> LGTM
Thanks, I'll ask a WK2 owner to approve.

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:124
> > +    if (m_state.solidColor.isValid() && !m_state.contentsRect.isEmpty() && m_state.solidColor.alpha()) {
> 
> Unrelated optimization, isn't it?
It isn't :)
Now that we support pattern compositing, if this is not there, this code path would be triggered and the pattern would not be drawn.

[Andreas Kling]

Comment on attachment 198850 [details]
Patch

wk2r=me

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 198850 [details]:

platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: [e-mail], [e-mail], and [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html bug 114209 (author: [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
svg/animations/smil-leak-elements.svg bug 114280 (authors: [e-mail] and [e-mail])
svg/animations/smil-leak-dynamically-added-element-instances.svg bug 114281 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 198850 [details]
Patch

Clearing flags on attachment: 198850

Committed r148748: <http://trac.webkit.org/changeset/148748>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.