Bug 122297 - MathML should look at font features
Summary: MathML should look at font features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 115786 128907 130233 130321 130322 130324 130325 133567 133569 153918 155638 155639 155714 155756
Blocks: 115789
  Show dependency treegraph
 
Reported: 2013-10-03 12:49 PDT by Martin Robinson
Modified: 2016-07-11 11:49 PDT (History)
27 users (show)

See Also:


Attachments
WIP Patch (23.05 KB, patch)
2014-02-14 07:58 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
testcase (requires STIX Math) (689 bytes, text/html)
2014-02-17 08:38 PST, Frédéric Wang (:fredw)
no flags Details
WIP Patch (35.37 KB, patch)
2014-02-17 08:40 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Screenshot with the patches applied (WebKitGTK+) (13.29 KB, image/png)
2014-02-17 08:44 PST, Frédéric Wang (:fredw)
no flags Details
WIP Patch (96.56 KB, patch)
2014-02-18 07:33 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Python script to extract the MATH data from the STIX Math fonts (5.43 KB, text/x-python)
2014-02-18 07:34 PST, Frédéric Wang (:fredw)
no flags Details
WIP Patch (223.20 KB, patch)
2014-02-19 09:39 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch V1 (221.94 KB, patch)
2014-02-19 11:57 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Screenshot of the torture test (STIX-Word WebKitGTK+) (8.27 KB, image/png)
2014-02-19 12:06 PST, Frédéric Wang (:fredw)
no flags Details
Patch (166.98 KB, patch)
2014-02-26 07:30 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Screenshot of the torture test (Latin-Modern WebKitGTK+) (41.74 KB, image/png)
2014-02-26 07:32 PST, Frédéric Wang (:fredw)
no flags Details
Another testcase (you can download it and modify the font-family) (7.08 KB, text/html)
2014-02-27 03:19 PST, Frédéric Wang (:fredw)
no flags Details
Patch for testing (217.44 KB, patch)
2014-02-27 04:26 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch for testing (217.95 KB, patch)
2014-02-27 07:05 PST, Frédéric Wang (:fredw)
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (2.95 MB, application/zip)
2014-02-27 09:21 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (635.72 KB, application/zip)
2014-02-27 10:14 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (601.67 KB, application/zip)
2014-02-27 11:23 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (639.22 KB, application/zip)
2014-02-27 11:24 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (608.58 KB, application/zip)
2014-02-27 12:45 PST, Build Bot
no flags Details
Patch (136.53 KB, patch)
2014-03-06 09:07 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch 124838+115787+115786+128907+122297 for testing (218.64 KB, patch)
2014-03-06 09:09 PST, Frédéric Wang (:fredw)
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (522.81 KB, application/zip)
2014-03-06 10:38 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (560.14 KB, application/zip)
2014-03-06 11:36 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (527.61 KB, application/zip)
2014-03-06 11:56 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (609.08 KB, application/zip)
2014-03-06 12:25 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (558.41 KB, application/zip)
2014-03-06 13:30 PST, Build Bot
no flags Details
Patch 124838+115787+115786+128907+122297 for testing (216.61 KB, patch)
2014-03-07 03:01 PST, Frédéric Wang (:fredw)
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (624.16 KB, application/zip)
2014-03-07 05:15 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (515.75 KB, application/zip)
2014-03-07 05:46 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (594.34 KB, application/zip)
2014-03-07 06:25 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (571.83 KB, application/zip)
2014-03-07 07:20 PST, Build Bot
no flags Details
Patch 124838+115787+115786+128907+122297 for testing (217.77 KB, patch)
2014-03-10 15:16 PDT, Frédéric Wang (:fredw)
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (500.41 KB, application/zip)
2014-03-10 16:48 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (532.59 KB, application/zip)
2014-03-10 17:49 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (547.34 KB, application/zip)
2014-03-10 17:51 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (668.20 KB, application/zip)
2014-03-10 18:37 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (668.24 KB, application/zip)
2014-03-10 19:31 PDT, Build Bot
no flags Details
Patch (136.67 KB, patch)
2014-03-12 08:39 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch + 128907 for testing (146.91 KB, patch)
2014-03-12 08:42 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch + 128907 for testing (147.32 KB, patch)
2014-03-13 10:10 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (129.28 KB, patch)
2014-03-14 04:15 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (129.46 KB, patch)
2014-03-14 14:41 PDT, Frédéric Wang (:fredw)
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (499.73 KB, application/zip)
2014-03-14 16:16 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (527.43 KB, application/zip)
2014-03-14 16:57 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (524.86 KB, application/zip)
2014-03-14 17:15 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (528.40 KB, application/zip)
2014-03-14 18:01 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (529.71 KB, application/zip)
2014-03-14 19:14 PDT, Build Bot
no flags Details
Patch (159.43 KB, patch)
2014-03-16 07:43 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (159.53 KB, patch)
2014-03-16 10:47 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-10-03 12:49:11 PDT
MathML should be looking at font features (for instance those found in OpenType) to determine replacements for stretching characters and to better position equation components
Comment 1 Frédéric Wang (:fredw) 2014-01-20 08:23:48 PST
I see that there are some stuff in platform/graphics/opentype/, but I don't know for what it is used for and on which platforms it is available.

Some updates on this:

- Since that was needed for Gecko, I've added support for the MATH table in OTS: https://codereview.chromium.org/139563002/

- Microsoft's MATH table is not yet public but has been submitted to the MPEG group in response to the 'Call for Proposals for ISO/IEC 14496-22 "Open Font Format" Color Font Technology and MATH layout support' (http://mpeg.chiariglione.org/standards/mpeg-4/open-font-format/call-proposals-isoiec-14496-22-open-font-format-color-font)
Comment 2 Frédéric Wang (:fredw) 2014-02-14 05:51:09 PST
I've done more testing on the MATH table yesterday. So my understanding is that:

- OTS is no longer used in WebKit (bug 68292), so the MATH support I added to OTS is not relevant here.

- The stuff in platform/graphics/opentype/ is only specific to EFL and GTK platforms at the moment, so we'll have to think about what to do for other platforms. For now, I think I'll follow https://www.webkit.org/coding/adding-features.html and add a new experimental feature OPENTYPE_MATH.

So far I've just try to connect the MathML code to the OpenType code. I have a patch to read the default linethickness of a fraction from the MATH table and to use it in the MathML rendering code. That seems to work with local and WOFF fonts. I plan to submit a patch later.
Comment 3 Frédéric Wang (:fredw) 2014-02-14 07:58:53 PST
Created attachment 224216 [details]
WIP Patch

So here is a proof-of-concept patch that reads the fraction linethickness from the MATH table in GTK/EFL. If you visit

http://www.maths-informatique-jeux.com/ulule/mathml_torture_test/fraction-linethickness.html

both fraction bars should have a .5em linethickness. The first by MathML attributes ; the second by the MATH table.
Comment 4 Frédéric Wang (:fredw) 2014-02-17 08:38:56 PST
Created attachment 224374 [details]
testcase (requires STIX Math)
Comment 5 Frédéric Wang (:fredw) 2014-02-17 08:40:09 PST
Created attachment 224375 [details]
WIP Patch

Here is an updated patch that applies on top of the one of bug 128907 and reads the glyph assembly from the MATH table.
Comment 6 Frédéric Wang (:fredw) 2014-02-17 08:44:59 PST
Created attachment 224379 [details]
Screenshot with the patches applied (WebKitGTK+)
Comment 7 Frédéric Wang (:fredw) 2014-02-18 07:33:25 PST
Created attachment 224508 [details]
WIP Patch

This new version adds support for size variants. However, the alignment and stretch size is not good. The improvements from bug 119043 should probably be taken before. There are a couple of rendering issues that would need bug 99620 too.

The ENABLE_OPENTYPE_MATH flag compilation now behaves like this:

- Enabled on ports that can read Open Type Tables (IIUC freetype & cg/cairo on windows). Then the MATH table is read and so any such open type font is supported. Try e.g. http://www.maths-informatique-jeux.com/ulule/mathml_torture_test/

- Disabled on other ports. In that case the data from the MATH table are hardcoded. Currently, only STIX Math is supported as I think it is installed by default on Mac. Hopefully we will be able to replace this with direct access to the MATH table in the future.
Comment 8 Frédéric Wang (:fredw) 2014-02-18 07:34:28 PST
Created attachment 224510 [details]
Python script to extract the MATH data from the STIX Math fonts
Comment 9 Frédéric Wang (:fredw) 2014-02-19 09:39:40 PST
Created attachment 224640 [details]
WIP Patch
Comment 10 Frédéric Wang (:fredw) 2014-02-19 11:57:44 PST
Created attachment 224662 [details]
Patch V1
Comment 11 Frédéric Wang (:fredw) 2014-02-19 12:06:22 PST
Created attachment 224663 [details]
Screenshot of the torture test (STIX-Word WebKitGTK+)

The previous patch integrates the changes from bug 99620, bug 119043 and 128907. That seems to work relatively well. Here is a screenshot for STIX-Word. You can try other MATH fonts here: http://www.maths-informatique-jeux.com/ulule/mathml_torture_test/. I still have to make the patch build on Windows/Mac and check if the glyph measuring/drawing works.
Comment 12 Frédéric Wang (:fredw) 2014-02-26 07:30:30 PST
Created attachment 225254 [details]
Patch

Refresh the patch. This adds largeop (always consider displaystyle for now).
Comment 13 Frédéric Wang (:fredw) 2014-02-26 07:32:54 PST
Created attachment 225255 [details]
Screenshot of the torture test (Latin-Modern WebKitGTK+)

Here is a screenshot that shows large integrals and sums. (the most obvious bugs are missing italic correction on scripts, no horizontal stretching and missing mathvariant).
Comment 14 Frédéric Wang (:fredw) 2014-02-27 03:19:22 PST
Created attachment 225353 [details]
Another testcase (you can download it and modify the font-family)
Comment 15 Frédéric Wang (:fredw) 2014-02-27 04:26:53 PST
Created attachment 225355 [details]
Patch for testing
Comment 16 Frédéric Wang (:fredw) 2014-02-27 07:05:43 PST
Created attachment 225366 [details]
Patch for testing

Trying to fix some build failures...
Comment 17 WebKit Commit Bot 2014-02-27 07:07:31 PST
Attachment 225366 [details] did not pass style-queue:


ERROR: Source/WebCore/mathml/MathMLInlineContainerElement.h:43:  The parameter name "change" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 Build Bot 2014-02-27 09:21:19 PST
Comment on attachment 225366 [details]
Patch for testing

Attachment 225366 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4956107214684160

New failing tests:
mathml/presentation/attributes-mathvariant.html
mathml/presentation/inferred-mrow-stretchy.html
mathml/presentation/mo-stretch.html
mathml/presentation/stretchy-depth-height-symmetric.html
mathml/presentation/bug97990.html
platform/mac/accessibility/mathml-elements.html
mathml/presentation/stretchy-depth-height.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/presentation/scripts-subsup.html
Comment 19 Build Bot 2014-02-27 09:21:23 PST
Created attachment 225377 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 20 Build Bot 2014-02-27 10:14:14 PST
Comment on attachment 225366 [details]
Patch for testing

Attachment 225366 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5611600291561472

New failing tests:
mathml/presentation/attributes-mathvariant.html
mathml/presentation/inferred-mrow-stretchy.html
mathml/presentation/bug97990.html
svg/masking/mask-negative-scale.svg
mathml/presentation/mo-stretch.html
mathml/presentation/stretchy-depth-height-symmetric.html
platform/mac/accessibility/mathml-elements.html
mathml/presentation/stretchy-depth-height.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/presentation/scripts-subsup.html
Comment 21 Build Bot 2014-02-27 10:14:19 PST
Created attachment 225388 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 22 Build Bot 2014-02-27 11:23:22 PST
Comment on attachment 225366 [details]
Patch for testing

Attachment 225366 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4562359007838208

New failing tests:
mathml/presentation/attributes-mathvariant.html
mathml/presentation/inferred-mrow-stretchy.html
mathml/presentation/mo-stretch.html
mathml/presentation/stretchy-depth-height-symmetric.html
mathml/presentation/bug97990.html
platform/mac/accessibility/mathml-elements.html
mathml/presentation/stretchy-depth-height.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/presentation/scripts-subsup.html
Comment 23 Build Bot 2014-02-27 11:23:26 PST
Created attachment 225399 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 24 Build Bot 2014-02-27 11:24:33 PST
Comment on attachment 225366 [details]
Patch for testing

Attachment 225366 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5242164384628736

New failing tests:
mathml/presentation/attributes-mathvariant.html
mathml/presentation/inferred-mrow-stretchy.html
mathml/presentation/bug97990.html
svg/masking/mask-negative-scale.svg
mathml/presentation/mo-stretch.html
mathml/presentation/stretchy-depth-height-symmetric.html
platform/mac/accessibility/mathml-elements.html
mathml/presentation/stretchy-depth-height.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/presentation/scripts-subsup.html
Comment 25 Build Bot 2014-02-27 11:24:38 PST
Created attachment 225400 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 26 Build Bot 2014-02-27 12:45:22 PST
Comment on attachment 225366 [details]
Patch for testing

Attachment 225366 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6174855724531712

New failing tests:
mathml/presentation/attributes-mathvariant.html
mathml/presentation/inferred-mrow-stretchy.html
mathml/presentation/bug97990.html
svg/masking/mask-negative-scale.svg
mathml/presentation/mo-stretch.html
mathml/presentation/stretchy-depth-height-symmetric.html
platform/mac/accessibility/mathml-elements.html
mathml/presentation/stretchy-depth-height.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/presentation/scripts-subsup.html
Comment 27 Build Bot 2014-02-27 12:45:27 PST
Created attachment 225401 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 28 Frédéric Wang (:fredw) 2014-03-06 09:07:18 PST
Created attachment 225998 [details]
Patch

This patch relies on the work of bug 128907 and preserves the old math fonts by default.
Comment 29 Frédéric Wang (:fredw) 2014-03-06 09:09:56 PST
Created attachment 225999 [details]
Patch 124838+115787+115786+128907+122297 for testing
Comment 30 Build Bot 2014-03-06 10:38:10 PST
Comment on attachment 225999 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 225999 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6624831931940864

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/fractions-linethickness.html
mathml/presentation/mo-stretch.html
Comment 31 Build Bot 2014-03-06 10:38:14 PST
Created attachment 226007 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 32 Build Bot 2014-03-06 11:35:58 PST
Comment on attachment 225999 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 225999 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6252974737195008

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/fractions-linethickness.html
mathml/presentation/mo-stretch.html
Comment 33 Build Bot 2014-03-06 11:36:05 PST
Created attachment 226017 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 34 Build Bot 2014-03-06 11:56:09 PST
Comment on attachment 225999 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 225999 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5544390764265472

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/fractions-linethickness.html
mathml/presentation/mo-stretch.html
Comment 35 Build Bot 2014-03-06 11:56:15 PST
Created attachment 226022 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 36 Build Bot 2014-03-06 12:25:16 PST
Comment on attachment 225999 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 225999 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5572263759839232

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/fractions-linethickness.html
mathml/presentation/mo-stretch.html
Comment 37 Build Bot 2014-03-06 12:25:22 PST
Created attachment 226025 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 38 Build Bot 2014-03-06 13:30:18 PST
Comment on attachment 225999 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 225999 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4642688150274048

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/fractions-linethickness.html
mathml/presentation/mo-stretch.html
Comment 39 Build Bot 2014-03-06 13:30:25 PST
Created attachment 226032 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 40 Frédéric Wang (:fredw) 2014-03-07 03:01:51 PST
Created attachment 226107 [details]
Patch 124838+115787+115786+128907+122297 for testing
Comment 41 Build Bot 2014-03-07 05:15:02 PST
Comment on attachment 226107 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226107 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6225898994925568

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/mo-stretch.html
Comment 42 Build Bot 2014-03-07 05:15:07 PST
Created attachment 226119 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 43 Build Bot 2014-03-07 05:45:56 PST
Comment on attachment 226107 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226107 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5292223839076352

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/mo-stretch.html
Comment 44 Build Bot 2014-03-07 05:46:03 PST
Created attachment 226120 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 45 Build Bot 2014-03-07 06:25:17 PST
Comment on attachment 226107 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226107 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4506743845421056

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/mo-stretch.html
Comment 46 Build Bot 2014-03-07 06:25:25 PST
Created attachment 226122 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 47 Build Bot 2014-03-07 07:20:23 PST
Comment on attachment 226107 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226107 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5491906263908352

New failing tests:
platform/mac/accessibility/mathml-elements.html
mathml/presentation/mo-stretch.html
Comment 48 Build Bot 2014-03-07 07:20:31 PST
Created attachment 226126 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 49 Frédéric Wang (:fredw) 2014-03-10 15:16:32 PDT
Created attachment 226338 [details]
Patch 124838+115787+115786+128907+122297 for testing
Comment 50 WebKit Commit Bot 2014-03-10 15:19:51 PDT
Attachment 226338 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/opentype/OpenTypeMathData.h:48:  The parameter name "platformData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 55 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 51 Build Bot 2014-03-10 16:48:02 PDT
Comment on attachment 226338 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226338 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5823104613875712

New failing tests:
mathml/presentation/mo-stretch.html
Comment 52 Build Bot 2014-03-10 16:48:11 PDT
Created attachment 226350 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 53 Build Bot 2014-03-10 17:49:10 PDT
Comment on attachment 226338 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226338 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5733496026824704

New failing tests:
mathml/presentation/mo-stretch.html
Comment 54 Build Bot 2014-03-10 17:49:23 PDT
Created attachment 226356 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 55 Build Bot 2014-03-10 17:51:35 PDT
Comment on attachment 226338 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226338 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6025493673410560

New failing tests:
mathml/presentation/mo-stretch.html
Comment 56 Build Bot 2014-03-10 17:51:47 PDT
Created attachment 226357 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 57 Build Bot 2014-03-10 18:37:14 PDT
Comment on attachment 226338 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226338 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6601005869301760

New failing tests:
mathml/presentation/mo-stretch.html
Comment 58 Build Bot 2014-03-10 18:37:28 PDT
Created attachment 226364 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 59 Build Bot 2014-03-10 19:30:57 PDT
Comment on attachment 226338 [details]
Patch 124838+115787+115786+128907+122297 for testing

Attachment 226338 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5446831119007744

New failing tests:
mathml/presentation/mo-stretch.html
Comment 60 Build Bot 2014-03-10 19:31:11 PDT
Created attachment 226371 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 61 Frédéric Wang (:fredw) 2014-03-12 08:39:48 PDT
Created attachment 226508 [details]
Patch
Comment 62 Frédéric Wang (:fredw) 2014-03-12 08:42:39 PDT
Created attachment 226510 [details]
Patch + 128907 for testing
Comment 63 Frédéric Wang (:fredw) 2014-03-13 10:10:28 PDT
Created attachment 226597 [details]
Patch + 128907 for testing

Trying to implement
Comment 64 Frédéric Wang (:fredw) 2014-03-13 10:11:05 PDT
(In reply to comment #63)
> Trying to implement
... a cache.
Comment 65 Frédéric Wang (:fredw) 2014-03-14 04:15:54 PDT
Created attachment 226680 [details]
Patch
Comment 66 WebKit Commit Bot 2014-03-14 04:17:23 PDT
Attachment 226680 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:1594:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:1622:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 67 Frédéric Wang (:fredw) 2014-03-14 14:41:38 PDT
Created attachment 226768 [details]
Patch
Comment 68 Build Bot 2014-03-14 16:16:16 PDT
Comment on attachment 226768 [details]
Patch

Attachment 226768 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6177913875464192

New failing tests:
mathml/presentation/mo-stretch.html
Comment 69 Build Bot 2014-03-14 16:16:27 PDT
Created attachment 226773 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 70 Build Bot 2014-03-14 16:56:56 PDT
Comment on attachment 226768 [details]
Patch

Attachment 226768 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5013578306289664

New failing tests:
mathml/presentation/mo-stretch.html
Comment 71 Build Bot 2014-03-14 16:57:11 PDT
Created attachment 226780 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 72 Build Bot 2014-03-14 17:15:07 PDT
Comment on attachment 226768 [details]
Patch

Attachment 226768 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5732714745430016

New failing tests:
mathml/presentation/mo-stretch.html
Comment 73 Build Bot 2014-03-14 17:15:22 PDT
Created attachment 226782 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 74 Build Bot 2014-03-14 18:01:29 PDT
Comment on attachment 226768 [details]
Patch

Attachment 226768 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5697530373341184

New failing tests:
mathml/presentation/mo-stretch.html
Comment 75 Build Bot 2014-03-14 18:01:46 PDT
Created attachment 226787 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 76 Build Bot 2014-03-14 19:14:25 PDT
Comment on attachment 226768 [details]
Patch

Attachment 226768 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6470236328951808

New failing tests:
mathml/presentation/mo-stretch.html
Comment 77 Build Bot 2014-03-14 19:14:41 PDT
Created attachment 226793 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 78 Frédéric Wang (:fredw) 2014-03-16 07:43:02 PDT
Created attachment 226840 [details]
Patch
Comment 79 Frédéric Wang (:fredw) 2014-03-16 10:47:09 PDT
Created attachment 226844 [details]
Patch

Refreshing because of merge conflicts after bug 130090...
Comment 80 Brent Fulgham 2016-07-11 11:46:26 PDT
Can you post a revised patch for this now that the dependent changes have landed?
Comment 81 Frédéric Wang (:fredw) 2016-07-11 11:49:55 PDT
(In reply to comment #80)
> Can you post a revised patch for this now that the dependent changes have
> landed?

This patch from 2014 is essentially subsumed by the work done in the past months. I believe we can close this bug since we now support the most important features of the MATH table. Other follow-up bugs can be opened for the remaining ones.