Bug 155639 – Use Fraction* parameters from the OpenType MATH table

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

The refactoring of bug 153917 tries to preserve the old layout for <mfrac>. We can improve it a bit by using the following parameters: 

DenominatorDisplayStyleGapMin	
DenominatorDisplayStyleShiftDown	
DenominatorGapMin	
DenominatorShiftDown	
NumeratorDisplayStyleGapMin	
NumeratorDisplayStyleShiftDown	
NumeratorGapMin	
NumeratorShiftDown	
FractionRuleThickness

[Frédéric Wang (:fredw)]

Created attachment 274539 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 277383 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 282057 [details]
Patch

[Brent Fulgham]

Comment on attachment 282057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282057&action=review

This looks fine, but doesn't apply against trunk. Is there a related patch is should depend on?

> Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:52
>      , m_denominatorAlign(FractionAlignmentCenter)

Could all of these constant initializations be moved to the header file as C++11 format?

> Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:248
> +        return Optional<int>(static_cast<int>(lroundf(m_ascent)));

"lroundf" should be std::lround(m_ascent)

You might need to #include <cmath>

[Frédéric Wang (:fredw)]

Created attachment 283143 [details]
Patch

[Build Bot]

Comment on attachment 283143 [details]
Patch

Attachment 283143 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1646766

New failing tests:
mathml/presentation/fractions-positions.html
mathml/presentation/roots.xhtml

[Build Bot]

Created attachment 283146 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283143 [details]
Patch

Attachment 283143 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1646779

New failing tests:
mathml/presentation/stretchy-depth-height-symmetric.html
mathml/presentation/fractions-positions.html
mathml/presentation/roots.xhtml

[Build Bot]

Created attachment 283148 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Build Bot]

Comment on attachment 283143 [details]
Patch

Attachment 283143 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1646837

New failing tests:
mathml/presentation/fractions-positions.html
mathml/presentation/roots.xhtml

[Build Bot]

Created attachment 283150 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283143 [details]
Patch

Attachment 283143 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1646848

New failing tests:
mathml/presentation/fractions-positions.html
mathml/presentation/roots.xhtml

[Build Bot]

Created attachment 283155 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Frédéric Wang (:fredw)]

Created attachment 283158 [details]
Patch

[Frédéric Wang (:fredw)]

Committed r202979: <http://trac.webkit.org/changeset/202979>