Bug 155714 - Use Stack* parameters from the OpenType MATH table
Summary: Use Stack* parameters from the OpenType MATH table
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL: http://tests.mathml-association.org/m...
Keywords:
Depends on: 153917 155639 158884
Blocks: displaystyle 122297 155756
  Show dependency treegraph
 
Reported: 2016-03-21 02:17 PDT by Frédéric Wang (:fredw)
Modified: 2016-07-11 11:43 PDT (History)
6 users (show)

See Also:


Attachments
Patch (28.49 KB, patch)
2016-03-21 02:37 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (31.04 KB, patch)
2016-04-26 09:05 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (31.04 KB, patch)
2016-06-25 00:40 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (31.25 KB, patch)
2016-07-08 08:46 PDT, Frédéric Wang (:fredw)
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-03-21 02:17:11 PDT
Follow up of bug 155639. When the linethickness of the fraction is 0, we can layout as a stack using the following parameters:

StackTopShiftUp
StackTopDisplayStyleShiftUp
StackBottomShiftDown
StackBottomDisplayStyleShiftDown
StackGapMin
StackDisplayStyleGapMin
Comment 1 Frédéric Wang (:fredw) 2016-03-21 02:37:55 PDT
Created attachment 274578 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2016-04-26 09:05:10 PDT
Created attachment 277384 [details]
Patch
Comment 3 Frédéric Wang (:fredw) 2016-06-25 00:40:29 PDT
Created attachment 282058 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2016-07-08 08:46:47 PDT
Created attachment 283166 [details]
Patch
Comment 5 Brent Fulgham 2016-07-11 09:51:54 PDT
Comment on attachment 283166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283166&action=review

Looks good to me. r=me.

> Source/WebCore/ChangeLog:17
> +        * rendering/mathml/RenderMathMLFraction.h: Define a isStack helper function and define

... Define AN isStack helper function ...

> Source/WebCore/rendering/mathml/RenderMathMLFraction.h:89
> +    };

For consistency, it seems like these two new unions should be placed above the FractionAlignment member variables.
Comment 6 Frédéric Wang (:fredw) 2016-07-11 11:43:12 PDT
Committed r203073: <http://trac.webkit.org/changeset/203073>