Bug 155714

Summary: Use Stack* parameters from the OpenType MATH table
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
URL: http://tests.mathml-association.org/mathml/presentation-markup/fractions/frac-parameters-2.html
Bug Depends on: 153917, 155639, 158884    
Bug Blocks: 118737, 122297, 155756    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch bfulgham: review+

Description Frédéric Wang (:fredw) 2016-03-21 02:17:11 PDT
Follow up of bug 155639. When the linethickness of the fraction is 0, we can layout as a stack using the following parameters:

StackTopShiftUp
StackTopDisplayStyleShiftUp
StackBottomShiftDown
StackBottomDisplayStyleShiftDown
StackGapMin
StackDisplayStyleGapMin
Comment 1 Frédéric Wang (:fredw) 2016-03-21 02:37:55 PDT
Created attachment 274578 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2016-04-26 09:05:10 PDT
Created attachment 277384 [details]
Patch
Comment 3 Frédéric Wang (:fredw) 2016-06-25 00:40:29 PDT
Created attachment 282058 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2016-07-08 08:46:47 PDT
Created attachment 283166 [details]
Patch
Comment 5 Brent Fulgham 2016-07-11 09:51:54 PDT
Comment on attachment 283166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283166&action=review

Looks good to me. r=me.

> Source/WebCore/ChangeLog:17
> +        * rendering/mathml/RenderMathMLFraction.h: Define a isStack helper function and define

... Define AN isStack helper function ...

> Source/WebCore/rendering/mathml/RenderMathMLFraction.h:89
> +    };

For consistency, it seems like these two new unions should be placed above the FractionAlignment member variables.
Comment 6 Frédéric Wang (:fredw) 2016-07-11 11:43:12 PDT
Committed r203073: <http://trac.webkit.org/changeset/203073>