try { document.appendChild(document); } catch (ex) { console.log(ex.name) } This logs "HIERARCHY_REQUEST_ERR" when it should log "HierarchyRequestError"
Created attachment 173731 [details] Patch
Sorry about the size of this patch. Maybe these are better done as a two step process where a rebaseline is done afterwards?
Does this match Firefox?
(In reply to comment #3) > Does this match Firefox? Yes, this matches the spec and Firefox (I added that to the ChangeLog but not to this bug).
I'm for this change.
Seems like a sensible change in general; is there any way to do this more incrementally? I have bad memories of patches this size. When a huge patch (even a seemingly mechanical one) causes a regression, it can be very hard to diagnose. Perhaps this could be done one exception at a time, or a few DOM classes at a time, instead of all at once.
(In reply to comment #6) > Seems like a sensible change in general; is there any way to do this more incrementally? I have bad memories of patches this size. When a huge patch (even a seemingly mechanical one) causes a regression, it can be very hard to diagnose. > > Perhaps this could be done one exception at a time, or a few DOM classes at a time, instead of all at once. Makes sense. I'll split the changes into smaller patches.
Comment on attachment 173731 [details] Patch I'm doing all of these one patch at a time.
All dependent bugs done.