Bug 102132 - Update DOMException name: NoDataAllowedError
Summary: Update DOMException name: NoDataAllowedError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks: 101606
  Show dependency tree / graph
 
Reported: 2012-11-13 13:54 PST by Erik Arvidsson
Modified: 2012-11-14 07:56 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2012-11-13 13:57 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch for landing (2.83 KB, patch)
2012-11-14 07:00 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch for landing (2.89 KB, patch)
2012-11-14 07:27 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-11-13 13:54:59 PST 
Update DOMException name: NoDataAllowedError
Comment 1 Erik Arvidsson 2012-11-13 13:57:06 PST 
Created attachment 173980 [details]
Patch
Comment 2 Darin Adler 2012-11-13 17:39:50 PST 
Comment on attachment 173980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173980&action=review

> Source/WebCore/dom/ExceptionCode.h:39
> +        NO_DATA_ALLOWED_ERR = 6, // Historical

That’s a confusing comment. "Not used in any spec or in our code" would be a better comment. And we should consider removing the constant entirely at some point.
Comment 3 Erik Arvidsson 2012-11-14 07:00:30 PST 
Created attachment 174149 [details]
Patch for landing
Comment 4 Erik Arvidsson 2012-11-14 07:00:52 PST 
(In reply to comment #2)
> (From update of attachment 173980 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173980&action=review
> 
> > Source/WebCore/dom/ExceptionCode.h:39
> > +        NO_DATA_ALLOWED_ERR = 6, // Historical
> 
> That’s a confusing comment. "Not used in any spec or in our code" would be a better comment. And we should consider removing the constant entirely at some point.

That is the terminology used in the spec. I'll compromise and a comment before the enum explaining this.
Comment 5 WebKit Review Bot 2012-11-14 07:04:52 PST 
Comment on attachment 174149 [details]
Patch for landing

Rejecting attachment 174149 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 1 cwd: /mnt/git/webkit-commit-queue

Parsed 3 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/dom/DOMCoreException.cpp
Hunk #1 FAILED at 40.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej
patching file Source/WebCore/dom/ExceptionCode.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14833315
Comment 6 Erik Arvidsson 2012-11-14 07:27:09 PST 
Created attachment 174154 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-11-14 07:56:20 PST 
Comment on attachment 174154 [details]
Patch for landing

Clearing flags on attachment: 174154

Committed r134610: <http://trac.webkit.org/changeset/134610>
Comment 8 WebKit Review Bot 2012-11-14 07:56:23 PST 
All reviewed patches have been landed.  Closing bug.