Bug 102132 – Update DOMException name: NoDataAllowedError

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Erik Arvidsson]

Update DOMException name: NoDataAllowedError

[Erik Arvidsson]

Created attachment 173980 [details]
Patch

[Darin Adler]

Comment on attachment 173980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173980&action=review

> Source/WebCore/dom/ExceptionCode.h:39
> +        NO_DATA_ALLOWED_ERR = 6, // Historical

That’s a confusing comment. "Not used in any spec or in our code" would be a better comment. And we should consider removing the constant entirely at some point.

[Erik Arvidsson]

Created attachment 174149 [details]
Patch for landing

[Erik Arvidsson]

(In reply to comment #2)
> (From update of attachment 173980 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173980&action=review
> 
> > Source/WebCore/dom/ExceptionCode.h:39
> > +        NO_DATA_ALLOWED_ERR = 6, // Historical
> 
> That’s a confusing comment. "Not used in any spec or in our code" would be a better comment. And we should consider removing the constant entirely at some point.

That is the terminology used in the spec. I'll compromise and a comment before the enum explaining this.

[WebKit Review Bot]

Comment on attachment 174149 [details]
Patch for landing

Rejecting attachment 174149 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 1 cwd: /mnt/git/webkit-commit-queue

Parsed 3 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/dom/DOMCoreException.cpp
Hunk #1 FAILED at 40.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej
patching file Source/WebCore/dom/ExceptionCode.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14833315

[Erik Arvidsson]

Created attachment 174154 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 174154 [details]
Patch for landing

Clearing flags on attachment: 174154

Committed r134610: <http://trac.webkit.org/changeset/134610>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.