Bug 102089 – Update DOMException name: DOMStringSizeError

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Erik Arvidsson]

Update DOMException name: DOMStringSizeError

[Erik Arvidsson]

Created attachment 173896 [details]
Patch

[Ojan Vafai]

Comment on attachment 173896 [details]
Patch

Can we just comment out the enum value with a short explanatory comment and get rid of the entry in coreExceptions?

[Erik Arvidsson]

(In reply to comment #2)
> (From update of attachment 173896 [details])
> Can we just comment out the enum value with a short explanatory comment and get rid of the entry in coreExceptions?

Yes, lets do that

https://bugs.webkit.org/show_bug.cgi?id=102095

[Erik Arvidsson]

Ojan, can I get an r+ on this one?

[WebKit Review Bot]

Comment on attachment 173896 [details]
Patch

Rejecting attachment 173896 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
le Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/dom/DOMCoreException.cpp
Hunk #1 FAILED at 36.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej
patching file Source/WebCore/dom/ExceptionCode.h
Hunk #1 succeeded at 35 with fuzz 1 (offset 3 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14848442

[Erik Arvidsson]

Created attachment 174492 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 174492 [details]
Patch for landing

Clearing flags on attachment: 174492

Committed r134840: <http://trac.webkit.org/changeset/134840>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.