Bug 102089 - Update DOMException name: DOMStringSizeError
Summary: Update DOMException name: DOMStringSizeError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks: 101606
  Show dependency tree / graph
 
Reported: 2012-11-13 08:09 PST by Erik Arvidsson
Modified: 2012-11-15 15:26 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2012-11-13 08:11 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch for landing (2.38 KB, patch)
2012-11-15 11:36 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-11-13 08:09:45 PST 
Update DOMException name: DOMStringSizeError
Comment 1 Erik Arvidsson 2012-11-13 08:11:04 PST 
Created attachment 173896 [details]
Patch
Comment 2 Ojan Vafai 2012-11-13 08:51:42 PST 
Comment on attachment 173896 [details]
Patch

Can we just comment out the enum value with a short explanatory comment and get rid of the entry in coreExceptions?
Comment 3 Erik Arvidsson 2012-11-13 08:59:51 PST 
(In reply to comment #2)
> (From update of attachment 173896 [details])
> Can we just comment out the enum value with a short explanatory comment and get rid of the entry in coreExceptions?

Yes, lets do that

https://bugs.webkit.org/show_bug.cgi?id=102095
Comment 4 Erik Arvidsson 2012-11-15 07:55:07 PST 
Ojan, can I get an r+ on this one?
Comment 5 WebKit Review Bot 2012-11-15 10:14:37 PST 
Comment on attachment 173896 [details]
Patch

Rejecting attachment 173896 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
le Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/dom/DOMCoreException.cpp
Hunk #1 FAILED at 36.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej
patching file Source/WebCore/dom/ExceptionCode.h
Hunk #1 succeeded at 35 with fuzz 1 (offset 3 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14848442
Comment 6 Erik Arvidsson 2012-11-15 11:36:58 PST 
Created attachment 174492 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-11-15 15:26:50 PST 
Comment on attachment 174492 [details]
Patch for landing

Clearing flags on attachment: 174492

Committed r134840: <http://trac.webkit.org/changeset/134840>
Comment 8 WebKit Review Bot 2012-11-15 15:26:53 PST 
All reviewed patches have been landed.  Closing bug.