Bug 102095 - Remove historical enums from ExceptionCode.h
Summary: Remove historical enums from ExceptionCode.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-13 08:59 PST by Erik Arvidsson
Modified: 2012-11-20 07:36 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.75 KB, patch)
2012-11-19 15:35 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (5.00 KB, patch)
2012-11-19 15:49 PST, Erik Arvidsson
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-11-13 08:59:10 PST
Some of these enums are never used and have been removed from the specs.
Comment 1 Erik Arvidsson 2012-11-19 15:35:44 PST
Created attachment 175057 [details]
Patch
Comment 2 Erik Arvidsson 2012-11-19 15:44:48 PST
This is not complete because INUSE_ATTRIBUTE_ERR is still being used by our code.
Comment 3 Erik Arvidsson 2012-11-19 15:48:06 PST
INUSE_ATTRIBUTE_ERR is used by setAttributeNode which has been removed from the DOM specs. So I think we need to keep it as long as we keep those methods.
Comment 4 Erik Arvidsson 2012-11-19 15:49:52 PST
Created attachment 175062 [details]
Patch
Comment 5 Ojan Vafai 2012-11-19 16:01:17 PST
Comment on attachment 175062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175062&action=review

> Source/WebCore/dom/DOMCoreException.cpp:39
> +    { 0, 0 }, // { DOMStringSizeError

Nit: extra open curly
Comment 6 Erik Arvidsson 2012-11-20 07:36:19 PST
Committed r135277: <http://trac.webkit.org/changeset/135277>