RESOLVED FIXED 102095
Remove historical enums from ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=102095
Summary Remove historical enums from ExceptionCode.h
Erik Arvidsson
Reported 2012-11-13 08:59:10 PST
Some of these enums are never used and have been removed from the specs.
Attachments
Patch (4.75 KB, patch)
2012-11-19 15:35 PST, Erik Arvidsson
no flags
Patch (5.00 KB, patch)
2012-11-19 15:49 PST, Erik Arvidsson
ojan: review+
Erik Arvidsson
Comment 1 2012-11-19 15:35:44 PST
Erik Arvidsson
Comment 2 2012-11-19 15:44:48 PST
This is not complete because INUSE_ATTRIBUTE_ERR is still being used by our code.
Erik Arvidsson
Comment 3 2012-11-19 15:48:06 PST
INUSE_ATTRIBUTE_ERR is used by setAttributeNode which has been removed from the DOM specs. So I think we need to keep it as long as we keep those methods.
Erik Arvidsson
Comment 4 2012-11-19 15:49:52 PST
Ojan Vafai
Comment 5 2012-11-19 16:01:17 PST
Comment on attachment 175062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175062&action=review > Source/WebCore/dom/DOMCoreException.cpp:39 > + { 0, 0 }, // { DOMStringSizeError Nit: extra open curly
Erik Arvidsson
Comment 6 2012-11-20 07:36:19 PST
Note You need to log in before you can comment on or make changes to this bug.