Bug 102416 - Update DOMException name: ValidationError
Summary: Update DOMException name: ValidationError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks: 101606
  Show dependency treegraph
 
Reported: 2012-11-15 11:44 PST by Erik Arvidsson
Modified: 2012-11-15 19:51 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.82 KB, patch)
2012-11-15 11:45 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-11-15 11:44:55 PST
Update DOMException name: ValidationError
Comment 1 Erik Arvidsson 2012-11-15 11:45:52 PST
Created attachment 174493 [details]
Patch
Comment 2 Kentaro Hara 2012-11-15 16:12:36 PST
Comment on attachment 174493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174493&action=review

Looks OK.

> Source/WebCore/dom/ExceptionCode.h:56
> +        VALIDATION_ERR = 16, // Historical

BTW, are you going to remove these enums once you have replaced all DOM exceptions?
Comment 3 Erik Arvidsson 2012-11-15 19:14:35 PST
(In reply to comment #2)
> (From update of attachment 174493 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174493&action=review
> 
> Looks OK.
> 
> > Source/WebCore/dom/ExceptionCode.h:56
> > +        VALIDATION_ERR = 16, // Historical
> 
> BTW, are you going to remove these enums once you have replaced all DOM exceptions?

That is the plan.

https://bugs.webkit.org/show_bug.cgi?id=102095
Comment 4 WebKit Review Bot 2012-11-15 19:51:44 PST
Comment on attachment 174493 [details]
Patch

Clearing flags on attachment: 174493

Committed r134882: <http://trac.webkit.org/changeset/134882>
Comment 5 WebKit Review Bot 2012-11-15 19:51:47 PST
All reviewed patches have been landed.  Closing bug.