WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 102416
Update DOMException name: ValidationError
https://bugs.webkit.org/show_bug.cgi?id=102416
Summary
Update DOMException name: ValidationError
Erik Arvidsson
Reported
2012-11-15 11:44:55 PST
Update DOMException name: ValidationError
Attachments
Patch
(2.82 KB, patch)
2012-11-15 11:45 PST
,
Erik Arvidsson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Erik Arvidsson
Comment 1
2012-11-15 11:45:52 PST
Created
attachment 174493
[details]
Patch
Kentaro Hara
Comment 2
2012-11-15 16:12:36 PST
Comment on
attachment 174493
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=174493&action=review
Looks OK.
> Source/WebCore/dom/ExceptionCode.h:56 > + VALIDATION_ERR = 16, // Historical
BTW, are you going to remove these enums once you have replaced all DOM exceptions?
Erik Arvidsson
Comment 3
2012-11-15 19:14:35 PST
(In reply to
comment #2
)
> (From update of
attachment 174493
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=174493&action=review
> > Looks OK. > > > Source/WebCore/dom/ExceptionCode.h:56 > > + VALIDATION_ERR = 16, // Historical > > BTW, are you going to remove these enums once you have replaced all DOM exceptions?
That is the plan.
https://bugs.webkit.org/show_bug.cgi?id=102095
WebKit Review Bot
Comment 4
2012-11-15 19:51:44 PST
Comment on
attachment 174493
[details]
Patch Clearing flags on attachment: 174493 Committed
r134882
: <
http://trac.webkit.org/changeset/134882
>
WebKit Review Bot
Comment 5
2012-11-15 19:51:47 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug