Bug 102400 - Update DOMException name: InvalidAccessError
Summary: Update DOMException name: InvalidAccessError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks: 101606
  Show dependency tree / graph
 
Reported: 2012-11-15 09:14 PST by Erik Arvidsson
Modified: 2012-11-16 07:44 PST (History)
2 users (show)

See Also:

Attachments
Patch (48.11 KB, patch)
2012-11-15 09:15 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch for landing (48.10 KB, patch)
2012-11-16 06:48 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-11-15 09:14:12 PST 
Update DOMException name: InvalidAccessError
Comment 1 Erik Arvidsson 2012-11-15 09:15:09 PST 
Created attachment 174461 [details]
Patch
Comment 2 Kentaro Hara 2012-11-15 16:15:32 PST 
Comment on attachment 174461 [details]
Patch

You might want to add a "Histrical" comment on ExceptionCode.h. (Instead of adding the "Historical" comment on each line, you can add the comment at the top of ExceptionCode enums.)
Comment 3 Erik Arvidsson 2012-11-16 06:13:37 PST 
(In reply to comment #2)
> (From update of attachment 174461 [details])
> You might want to add a "Histrical" comment on ExceptionCode.h. (Instead of adding the "Historical" comment on each line, you can add the comment at the top of ExceptionCode enums.)

There is a comment above the enum explaining what is going regarding the historical error types.
Comment 4 Erik Arvidsson 2012-11-16 06:48:19 PST 
Created attachment 174674 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-11-16 07:44:48 PST 
Comment on attachment 174674 [details]
Patch for landing

Clearing flags on attachment: 174674

Committed r134949: <http://trac.webkit.org/changeset/134949>
Comment 6 WebKit Review Bot 2012-11-16 07:44:52 PST 
All reviewed patches have been landed.  Closing bug.