Update DOMException name: NetworkError
Created attachment 174679 [details] Patch
Comment on attachment 174679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174679&action=review ok > Source/WebCore/dom/DOMCoreException.cpp:56 > // FIXME: Couldn't find a description in the HTML/DOM specifications for NETWORK_ERR, ABORT_ERR, URL_MISMATCH_ERR, and QUOTA_EXCEEDED_ERR Given that they are not speced nor used in WebKit, maybe it's time to remove them from WebKit? You can do it in a follow-up patch if needed.
(In reply to comment #2) > (From update of attachment 174679 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174679&action=review > > ok > > > Source/WebCore/dom/DOMCoreException.cpp:56 > > // FIXME: Couldn't find a description in the HTML/DOM specifications for NETWORK_ERR, ABORT_ERR, URL_MISMATCH_ERR, and QUOTA_EXCEEDED_ERR > > Given that they are not speced nor used in WebKit, maybe it's time to remove them from WebKit? You can do it in a follow-up patch if needed. These have descriptions in the latest spec. I have an open bug to fix these to. Bug 101953. These are used but this is partially covered by bug 102506 .
Comment on attachment 174679 [details] Patch Rejecting attachment 174679 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/DOMCoreException.cpp Hunk #1 FAILED at 54. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14909217
Created attachment 174974 [details] Patch for landing
Comment on attachment 174974 [details] Patch for landing Clearing flags on attachment: 174974 Committed r135157: <http://trac.webkit.org/changeset/135157>
All reviewed patches have been landed. Closing bug.