Bug 102503 - Update DOMException name: NetworkError
Summary: Update DOMException name: NetworkError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks: 101606
  Show dependency tree / graph
 
Reported: 2012-11-16 07:08 PST by Erik Arvidsson
Modified: 2012-11-19 07:35 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2012-11-16 07:21 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch for landing (1.92 KB, patch)
2012-11-19 07:04 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-11-16 07:08:34 PST 
Update DOMException name: NetworkError
Comment 1 Erik Arvidsson 2012-11-16 07:21:26 PST 
Created attachment 174679 [details]
Patch
Comment 2 Kentaro Hara 2012-11-18 16:05:07 PST 
Comment on attachment 174679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174679&action=review

ok

> Source/WebCore/dom/DOMCoreException.cpp:56
>      // FIXME: Couldn't find a description in the HTML/DOM specifications for NETWORK_ERR, ABORT_ERR, URL_MISMATCH_ERR, and QUOTA_EXCEEDED_ERR

Given that they are not speced nor used in WebKit, maybe it's time to remove them from WebKit? You can do it in a follow-up patch if needed.
Comment 3 Erik Arvidsson 2012-11-19 06:12:37 PST 
(In reply to comment #2)
> (From update of attachment 174679 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174679&action=review
> 
> ok
> 
> > Source/WebCore/dom/DOMCoreException.cpp:56
> >      // FIXME: Couldn't find a description in the HTML/DOM specifications for NETWORK_ERR, ABORT_ERR, URL_MISMATCH_ERR, and QUOTA_EXCEEDED_ERR
> 
> Given that they are not speced nor used in WebKit, maybe it's time to remove them from WebKit? You can do it in a follow-up patch if needed.

These have descriptions in the latest spec. I have an open bug to fix these to. Bug 101953.

These are used but this is partially covered by bug 102506 .
Comment 4 WebKit Review Bot 2012-11-19 06:26:37 PST 
Comment on attachment 174679 [details]
Patch

Rejecting attachment 174679 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/dom/DOMCoreException.cpp
Hunk #1 FAILED at 54.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14909217
Comment 5 Erik Arvidsson 2012-11-19 07:04:00 PST 
Created attachment 174974 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-11-19 07:35:51 PST 
Comment on attachment 174974 [details]
Patch for landing

Clearing flags on attachment: 174974

Committed r135157: <http://trac.webkit.org/changeset/135157>
Comment 7 WebKit Review Bot 2012-11-19 07:35:55 PST 
All reviewed patches have been landed.  Closing bug.