Bug 68822
| Summary: | Add a way to allow adding cc's or messages to bugs based on patch contents. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Levin <levin> |
| Component: | Tools / Tests | Assignee: | David Levin <levin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 68823, 68850, 68869, 68871, 68904, 68917, 68950, 68972, 68973, 68974, 68975, 68976, 68991, 69031, 69288, 69303, 69484, 69486, 69487 | ||
| Bug Blocks: | |||
David Levin
The general idea is to have a file which file and/or code regexs and based on what matches add a cc or message to a bug.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
Here's an example file to give an idea of the syntax:
{
"DEFINITIONS": {
"ThreadingFiles": {
"filename": (r"Source/JavaScriptCore/wtf/RefCountedThreadSafe\.h"
r"|Source/WebCore/platform/CrossThreadCopier\.h"),
},
"ThreadingStructures": {
"added": r"RefCountedThreadSafe|deprecatedTurnOffVerifier|AtomicallyInitializedStatic",
},
"deprecatedTurnOffVerifier": {
"added": r"deprecatedTurnOffVerifier",
},
},
"CC_RULES": {
"ThreadingFiles|ThreadingStructures": [ "levin@chromium.org", ],
},
"CC_MESSAGES": {
"deprecatedTurnOffVerifier": [ "Whoa there grasshopper, don't use deprecatedTurnOffVerifier. It has deprecated in the method name for a reason!", ]
}
}
The file will be at Tools/Scripts/webkitpy/common/config/watch_list
David Levin
Address https://bugs.webkit.org/show_bug.cgi?id=68973#c16 before resolving.
David Levin
This is now launched -- https://wiki.webkit.org/wiki/WatchList