watchlist: Should be more robust to bad regex.

[David Levin]

It is easy to enter a bad regex for a definition, etc. We shouldn't turn every style run red and other definitions should still be run.

[David Levin]

Created attachment 111556 [details]
Patch

[Adam Barth]

Comment on attachment 111556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111556&action=review

> Tools/Scripts/webkitpy/common/watchlist/amountchangedpattern.py:32
> +    def __init__(self, compile_regex, index_for_zero_value):
> +        self._regex = compile_regex

compile_regex => compiled_regex ?

> Tools/Scripts/webkitpy/common/watchlist/changedlinepattern.py:32
> +    def __init__(self, compile_regex, index_for_zero_value):
> +        self._regex = compile_regex

Same question.

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:114
> +                except Exception, e:

Can we catch a more specific exception here?  I bet there's a specific exception for regexes failing to compile.

[WebKit Review Bot]

Comment on attachment 111556 [details]
Patch

Clearing flags on attachment: 111556

Committed r97885: <http://trac.webkit.org/changeset/97885>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.