WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70358
watchlist: Should try to run if it can and not throw on mistakes.
https://bugs.webkit.org/show_bug.cgi?id=70358
Summary
watchlist: Should try to run if it can and not throw on mistakes.
David Levin
Reported
2011-10-18 13:35:28 PDT
It is too easy for someone to introduce a mistake and then break the watchlist for everyone. This is a precursor to dealing with bad regex and hooking this up to the style checker.
Attachments
Patch
(22.33 KB, patch)
2011-10-18 13:44 PDT
,
David Levin
abarth
: review+
abarth
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2011-10-18 13:44:38 PDT
Created
attachment 111495
[details]
Patch
David Levin
Comment 2
2011-10-18 13:55:20 PDT
btw, the stuff about allowing a custom logger is so that I can put in something that goes directly to the style logger when I hook up style checking.
Adam Barth
Comment 3
2011-10-18 15:00:09 PDT
Comment on
attachment 111495
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=111495&action=review
> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:145 > - for email in cc_rule.instructions(): > + for email in cc_rule.instructions()[:]:
Is this a stealth copy? Is there a way to make this more explicit?
> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:147 > + cc_rule.remove_instruction(email)
Ah, I see.
David Levin
Comment 4
2011-10-18 18:37:11 PDT
Committed as
http://trac.webkit.org/changeset/97820
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug