Bug 68917 - watchlist: Add the filename pattern for definitions.
Summary: watchlist: Add the filename pattern for definitions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks: 68822
  Show dependency treegraph
 
Reported: 2011-09-27 11:06 PDT by David Levin
Modified: 2011-09-27 13:00 PDT (History)
2 users (show)

See Also:


Attachments
Patch (12.11 KB, patch)
2011-09-27 11:12 PDT, David Levin
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-09-27 11:06:52 PDT
See summary.
Comment 1 David Levin 2011-09-27 11:12:10 PDT
Created attachment 108870 [details]
Patch
Comment 2 Adam Barth 2011-09-27 11:56:19 PDT
Comment on attachment 108870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108870&action=review

> Tools/Scripts/webkitpy/common/watchlist/watchlist.py:32
> +# The "set" type only became available in Python 2.6.
> +# It was an imort before that.

Really?  I thought we used that all over the place.
Comment 3 David Levin 2011-09-27 11:59:28 PDT
(In reply to comment #2)
> (From update of attachment 108870 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108870&action=review
> 
> > Tools/Scripts/webkitpy/common/watchlist/watchlist.py:32
> > +# The "set" type only became available in Python 2.6.
> > +# It was an imort before that.
> 
> Really?  I thought we used that all over the place.

It looks like we do. My mistake it is "New in version 2.4."
I'll remove this. (I only havw python 2.6, so I had not verified this.)
Comment 4 David Levin 2011-09-27 13:00:44 PDT
Committed as http://trac.webkit.org/changeset/96144