Bug 68974 - watchlist: Make watchlist run on a bot.
Summary: watchlist: Make watchlist run on a bot.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on: 69288
Blocks: 68822
  Show dependency treegraph
 
Reported: 2011-09-27 23:14 PDT by David Levin
Modified: 2011-10-03 14:44 PDT (History)
0 users

See Also:


Attachments
Patch (8.50 KB, patch)
2011-10-03 14:12 PDT, David Levin
no flags Details | Formatted Diff | Diff
Patch (3.43 KB, patch)
2011-10-03 14:13 PDT, David Levin
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-09-27 23:14:51 PDT
Likely just run with the stylebot.
Comment 1 David Levin 2011-10-03 14:12:28 PDT
Created attachment 109528 [details]
Patch
Comment 2 David Levin 2011-10-03 14:13:37 PDT
Created attachment 109529 [details]
Patch
Comment 3 Adam Barth 2011-10-03 14:17:04 PDT
Comment on attachment 109529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109529&action=review

> Tools/Scripts/webkitpy/tool/commands/queues_unittest.py:416
> -            "process_work_item": "MOCK: update_status: style-queue Pass\nMOCK: release_work_item: style-queue 10000\n",
> +            "process_work_item": "MOCK run_and_throw_if_fail: ['echo', '--status-host=example.com', 'check-style', '--force-clean', '--non-interactive', '--parent-command=style-queue', 10000], cwd=/mock-checkout\nMOCK run_and_throw_if_fail: ['echo', '--status-host=example.com', 'apply-watchlist-local', 50000], cwd=/mock-checkout\nMOCK: update_status: style-queue Pass\nMOCK: release_work_item: style-queue 10000\n",

When these lines get long, we tend to use heredoc comments """blah
blah
blah"""
to make it easier to read (and to see the diffs).
Comment 4 David Levin 2011-10-03 14:44:00 PDT
Committed as http://trac.webkit.org/changeset/96541