Bug 68972 - watchlist: Add support for matching added or deleted lines.
Summary: watchlist: Add support for matching added or deleted lines.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
Depends on:
Blocks: 68822
  Show dependency treegraph
Reported: 2011-09-27 23:03 PDT by David Levin
Modified: 2011-09-28 10:05 PDT (History)
5 users (show)

See Also:

Patch (13.11 KB, patch)
2011-09-27 23:15 PDT, David Levin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-09-27 23:03:17 PDT
Note that added or deleted lines is simply based on the diff file itself -- not based on intraline diffing, so if someone changes a line containing "foo". Then "foo" will be in both added and deleted lines.
Comment 1 David Levin 2011-09-27 23:15:40 PDT
Created attachment 108969 [details]
Comment 2 Adam Barth 2011-09-28 09:48:53 PDT
Comment on attachment 108969 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=108969&action=review

> Tools/Scripts/webkitpy/common/watchlist/changedlinepattern.py:32
> +class ChangedLinePattern:

Sometimes we put trivial classes that are only used in one place in the same file as the use, but it doesn't really matter.

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:52
> +            }

Technically should be less indented.
Comment 3 WebKit Review Bot 2011-09-28 10:05:02 PDT
Comment on attachment 108969 [details]

Clearing flags on attachment: 108969

Committed r96228: <http://trac.webkit.org/changeset/96228>
Comment 4 WebKit Review Bot 2011-09-28 10:05:07 PDT
All reviewed patches have been landed.  Closing bug.