RESOLVED FIXED 69031
watchlist: Add a way to detect a net increase or decrease of a pattern (in a file). 
https://bugs.webkit.org/show_bug.cgi?id=69031
Summary watchlist: Add a way to detect a net increase or decrease of a pattern (in a ...
David Levin
Reported 2011-09-28 14:38:27 PDT
The idea is that to attempt a regex match. When there is a regex match, use the exact match and count additions and removals and do a diff to determine if it the pattern is a match. This allows one to have a pattern like this: more_in_code: r'RefCountedThreadSafe<|RefCounted<' and then the pattern matches if the number of ThreadSafeRefCount< or RefCounted< increased in any file (even if one was replaced by the other). This is a simple way to do mimic an intraline diff and say that the an occurrence of a string is new (which is typically what people would want to see).
Attachments
Patch (13.95 KB, patch)
2011-09-30 17:14 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-09-30 17:14:38 PDT
Created attachment 109378 [details] Patch
Adam Barth
Comment 2 2011-09-30 17:25:56 PDT
Comment on attachment 109378 [details] Patch Ok. My sense is you should wire this up to a real bot pretty soon so we can get experience. Ship first, ask questions later!
David Levin
Comment 3 2011-09-30 17:27:45 PDT
fwiw, I think this one is by far more useful than added_in_lines (and I may remove "added/remove_in_line" in the future).
Adam Barth
Comment 4 2011-09-30 17:32:27 PDT
(In reply to comment #3) > fwiw, I think this one is by far more useful than added_in_lines (and I may remove "added/remove_in_line" in the future). Oh definitely. This looks very cool. I still think you should ship early and often. :)
WebKit Review Bot
Comment 5 2011-09-30 17:39:00 PDT
Comment on attachment 109378 [details] Patch Clearing flags on attachment: 109378 Committed r96441: <http://trac.webkit.org/changeset/96441>
WebKit Review Bot
Comment 6 2011-09-30 17:39:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.