Bug 68950 - watchlist: Add support for cc and message rules.
Summary: watchlist: Add support for cc and message rules.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
Depends on:
Blocks: 68822
  Show dependency treegraph
Reported: 2011-09-27 16:15 PDT by David Levin
Modified: 2011-09-27 16:42 PDT (History)
2 users (show)

See Also:

Patch (14.48 KB, patch)
2011-09-27 16:22 PDT, David Levin
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-09-27 16:15:44 PDT
This is to list emails or messages to add to a bug when a definition matches a patch.
Comment 1 David Levin 2011-09-27 16:22:33 PDT
Created attachment 108925 [details]
Comment 2 Adam Barth 2011-09-27 16:27:48 PDT
Comment on attachment 108925 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=108925&action=review

> Tools/Scripts/webkitpy/common/watchlist/watchlist.py:81
> +            'messages':  self.determine_messages(definitions), }

PEP8 would tell you to put the } on the next line.
Comment 3 David Levin 2011-09-27 16:42:40 PDT
Committed as http://trac.webkit.org/changeset/96170 

(And addressed Adam's comment.)