[EFL] Add unit test cases for ewk_settings APIs

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Jose Lejin PJ]

In /trunk/Source/WebKit/efl/tests/test_ewk_setting.cpp unit test cases to be added for all APIs in ewk_settings(WK1)

[Jose Lejin PJ]

Created attachment 198936 [details]
Patch

Unit tests for needed APIs

[Jinwoo Song]

Comment on attachment 198936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198936&action=review

> Source/WebKit/efl/tests/test_ewk_setting.cpp:39
> +    ASSERT_EQ(ewk_settings_web_database_default_quota_get(), 1 * 1024 * 1024);

Expected value should be at first and actual value should be followed.
https://code.google.com/p/googletest/wiki/Primer

> Source/WebKit/efl/tests/test_ewk_setting.cpp:42
> +    ASSERT_EQ(ewk_settings_web_database_default_quota_get(), 2 * 1024 * 1024);

ditto.

> Source/WebKit/efl/tests/test_ewk_setting.cpp:45
> +    ASSERT_EQ(ewk_settings_web_database_default_quota_get(), 3 * 1024 * 1024);

ditto.

[Gyuyoung Kim]

Comment on attachment 198936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198936&action=review

> Source/WebKit/efl/tests/test_ewk_setting.cpp:137
> +    ewk_settings_object_cache_enable_set(EINA_FALSE);

IIRC, we decided to use standard boolean in API test.

> Source/WebKit/efl/tests/test_ewk_setting.cpp:140
> +    ewk_settings_object_cache_enable_set(EINA_TRUE);

ditto.

> Source/WebKit/efl/tests/test_ewk_setting.cpp:151
> +    ewk_settings_shadow_dom_enable_set(EINA_TRUE);

ditto.

> Source/WebKit/efl/tests/test_ewk_setting.cpp:154
> +    ewk_settings_shadow_dom_enable_set(EINA_FALSE);

ditto.

[Jose Lejin PJ]

Thanks for review Jinwoo Song/Gyuyoung Kim. I will update the patch.

[Jose Lejin PJ]

Created attachment 199156 [details]
Patch

Updated as per review

[Gyuyoung Kim]

Comment on attachment 199156 [details]
Patch

LGTM.

[Jose Lejin PJ]

Comment on attachment 199156 [details]
Patch

requesting for cq.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 199156 [details]:

media/video-played-collapse.html bug 58630 (authors: [e-mail], [e-mail], [e-mail], and [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/multiple-shadow-transitions.html bug 114187 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/negative-delay.html bug 114190 (author: [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: [e-mail], [e-mail], and [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 199156 [details]
Patch

Clearing flags on attachment: 199156

Committed r149032: <http://trac.webkit.org/changeset/149032>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 115151

[Gyuyoung Kim]

Though WebKit doesn't like to roll out, I did it because of API test failing.

http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release/builds/11912

This patch used wrong default storage path, and also didn't consider $HOME path. Sorry for missing it.

[Jose Lejin PJ]

Created attachment 199649 [details]
Patch

Updated with correct default path

[Jose Lejin PJ]

Created attachment 199778 [details]
Patch

Updated patch

[Gyuyoung Kim]

Comment on attachment 199778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199778&action=review

> Source/WebKit/efl/tests/test_ewk_setting.cpp:55
> +    strncpy(defaultPath, getenv("HOME"), sizeof(defaultPath));   

How about below case ?

 char* homePath = getenv("HOME");
 char* defaultPath = reinterpret_cast<char*>(malloc(strlen(homePath) + strlen("/.cache/WebKitEfl/Databases") + 1));
 strncpy(defaultPath, homePath, strlen(homePath) + 1);

> Source/WebKit/efl/tests/test_ewk_setting.cpp:82
> +    strncpy(defaultPath, getenv("HOME"), sizeof(defaultPath));   

ditto ?

> Source/WebKit/efl/tests/test_ewk_setting.cpp:112
> +    strncpy(defaultPath, getenv("HOME"), sizeof(defaultPath));   

ditto ?

[Jose Lejin PJ]

Created attachment 199791 [details]
Patch

Updated patch

[Gyuyoung Kim]

Comment on attachment 199791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199791&action=review

> Source/WebKit/efl/tests/test_ewk_setting.cpp:54
> +    char* defaultPath = reinterpret_cast<char*>(malloc(strlen(homePath) + strlen("/.cache/WebKitEfl/Databases") + 1));

Missing free() ?

> Source/WebKit/efl/tests/test_ewk_setting.cpp:84
> +    char* defaultPath = reinterpret_cast<char*>(malloc(strlen(homePath) + strlen("/.local/share/WebKitEfl/LocalStorage") + 1));

ditto.

> Source/WebKit/efl/tests/test_ewk_setting.cpp:116
> +    char* defaultPath = reinterpret_cast<char*>(malloc(strlen(homePath) + strlen("/.cache/WebKitEfl/Applications") + 1));

ditto.

[Jose Lejin PJ]

(In reply to comment #17)
> (From update of attachment 199791 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199791&action=review
> 
> > Source/WebKit/efl/tests/test_ewk_setting.cpp:54
> > +    char* defaultPath = reinterpret_cast<char*>(malloc(strlen(homePath) + strlen("/.cache/WebKitEfl/Databases") + 1));
> 
> Missing free() ?

sorry :) Will correct it.

[Jose Lejin PJ]

Created attachment 199806 [details]
Patch

Updated patch

[Gyuyoung Kim]

Comment on attachment 199806 [details]
Patch

LGTM now. Please land this patch after verifying to run WK1 API test.

[Jose Lejin PJ]

Comment on attachment 199806 [details]
Patch

Tested all API unit tests. Pass 10/10.

[WebKit Commit Bot]

Comment on attachment 199806 [details]
Patch

Clearing flags on attachment: 199806

Committed r149174: <http://trac.webkit.org/changeset/149174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.