Bug 46380 – REGRESSION: Crash when downloading a file

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

On attempting to open a resource with a "Content-Disposition" header set to "attachment" in the latest nightly build I see a "Failed to load resource" error in the browser's console. In many cases I am still able to download the attachment (see http://trac.webkit.org/raw-attachment/wiki/QtWebKit/CodeCamp200912/ARM-JIT.pdf as an example) however the error appears to halt any javascript running on the page which can break page behavior any time a user clicks on an attachment link.

This behaviors appears to be consistent on the webkit nightly (r68077) and the current chromium nightly (60289).

[Alexey Proskuryakov]

Could you please provide steps to reproduce this problem? What sites are you seeing it on?

Reproduction:

1. Open developer console.
2. Run the following Javascript to demonstrate a recurring event:
`x = setInterval(function() {console.log(new Date())}, 1000);` 
3. Load http://trac.webkit.org/raw-attachment/wiki/QtWebKit/CodeCamp200912/ARM-JIT.pdf
4. Note "Failed to load resource" error in console, javascript has stopped and no longer logs times to the console.

[Alexey Proskuryakov]

The latest nightly crashes for me when following these steps. Either way, it's no good.

[Alexey Proskuryakov]

I don't understand how this could not crash for you. Are you perhaps running Safari in 32-bit mode?

[Alexey Proskuryakov]

Created attachment 68619 [details]
proposed fix

As mysterious as it is, let's at least fix the crasher, and see if that magically helps.

[Alexey Proskuryakov]

*** Bug 46438 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46441 has been marked as a duplicate of this bug. ***

In case it's any help, I can reproduce the issue as described above in Chrome 6.0.472.63 and Safari 5.0.2 (6533.18.5).

[Alexey Proskuryakov]

OK, that explains the mystery - I'm fixing a completely different issue, not what you reported.

But I definitely cannot reproduce this in Safari 5.0.2. Here is what I've been doing:

1. Open a new Safari window.
2. Type "about:blank" (no quote marks) into address bar, press enter.
3. Press Cmd+Shift+C to open Web Inspector.
4. Run the following Javascript in Web Inspector console:
x = setInterval(function() {console.log(new Date())}, 1000);
5. Paste "http://trac.webkit.org/raw-attachment/wiki/QtWebKit/CodeCamp200912/ARM-JIT.pdf" into address bar (over "about:blank")

There is a "failed to load resource" error in console, but the timer keeps running.

[Darin Adler]

Comment on attachment 68619 [details]
proposed fix

Thank you for fixing this regression I just caused!

[Alexey Proskuryakov]

Fixed in <http://trac.webkit.org/changeset/68266>.

I'm sorry for pre-empting this bug report to fix a completely different issue. I think that it makes most sense to close this bug now, and to file a new one for the issue you are seeing.

Could you please file it? I'm still unable to reproduce the problem, so some more detail would help.

Sorry Alexey, looks like I got my test outputs confused, you're correct that Safari 5.0.2 reports "Failed to load resource: Frame load interrupted" and continues to fire javascript timers as expected.
I'll repeat my test with more detail and open a new bug.

Re-created as https://bugs.webkit.org/show_bug.cgi?id=46491

[Mark Rowe (bdash)]

*** Bug 46508 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46507 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46549 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46568 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46575 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46569 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46577 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46620 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46569 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46574 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 46661 has been marked as a duplicate of this bug. ***