Bug 220749 - [run-webkit-tests] Support python layout tests
Summary: [run-webkit-tests] Support python layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Gambrell
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-19 15:07 PST by Jonathan Bedard
Modified: 2021-05-24 10:26 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2021-01-19 15:10 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2021-01-22 09:58 PST, Jonathan Bedard 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (47.22 KB, patch)
2021-01-22 12:23 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (47.31 KB, patch)
2021-01-22 19:09 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-01-19 15:07:04 PST 
PHP is advertised as deprecated in Big Sur. We need to evaluate converting our PHP tests to something else, most likely Python. The first step of that is allowing apache to actually run Python files.
Comment 1 Radar WebKit Bug Importer 2021-01-19 15:07:15 PST 
<rdar://problem/73375271>
Comment 2 Jonathan Bedard 2021-01-19 15:10:44 PST 
Created attachment 417918 [details]
Patch
Comment 3 Alexey Proskuryakov 2021-01-19 16:41:10 PST 
Comment on attachment 417918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417918&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:164
> +        for index in range(len(httpd_conf)):

Why does this need to be done dynamically? I would expect all handlers to be defined in httpd.conf.
Comment 4 Alexey Proskuryakov 2021-01-19 16:41:41 PST 
Comment on attachment 417918 [details]
Patch

Marking r- because this breaks tests (we have .py files already).
Comment 5 Jonathan Bedard 2021-01-22 09:58:04 PST 
Created attachment 418156 [details]
Patch
Comment 6 Jonathan Bedard 2021-01-22 12:23:19 PST 
Created attachment 418169 [details]
Patch
Comment 7 Jonathan Bedard 2021-01-22 12:25:01 PST 
(In reply to Jonathan Bedard from comment #6)
> Created attachment 418169 [details]
> Patch

This is most of the change, there are still 3 cases we need to resolve, but the specifics of those cases makes me think it would be best to make those changes in separate bugs.
Comment 8 Jonathan Bedard 2021-01-22 19:09:40 PST 
Created attachment 418206 [details]
Patch
Comment 9 EWS 2021-01-25 16:33:49 PST 
Committed r271867: <https://trac.webkit.org/changeset/271867>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418206 [details].