Bug 223234 – [LayoutTests] Convert http/tests/referrer-policy convert PHP to Python

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Gambrell]

Replacing PHP with equivalent Python CGI scripts

[Radar WebKit Bug Importer]

<rdar://problem/75460136>

[Chris Gambrell]

Created attachment 423286 [details]
Patch

[Chris Gambrell]

Created attachment 424797 [details]
Patch

[Chris Gambrell]

Comment on attachment 424797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424797&action=review

> LayoutTests/ChangeLog:69
> +        * http/tests/referrer-policy/resources/script.php: Removed.

File not used by any tests

[Chris Gambrell]

Created attachment 424819 [details]
Patch

[Chris Gambrell]

Comment on attachment 424819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424819&action=review

> LayoutTests/http/tests/navigation/ping-attribute/resources/utilities.js:-29
> -    xhr.open("GET", "../../resources/delete-ping.php", true /* async */);

Referred to http/tests/resources/delete-ping.php instead of http/tests/navigation/resources/delete-ping.php

[Jonathan Bedard]

Comment on attachment 424819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424819&action=review

> LayoutTests/http/tests/css/resources/webfont-request.py:9
> +http_root = os.path.dirname(os.path.dirname(os.path.abspath(os.path.dirname(file))))

I don't see us using this path

> LayoutTests/http/tests/referrer-policy/resources/image.py:17
> +with open(os.path.join('/'.join(__file__.split('/')[0:-1]), '../../security/contentSecurityPolicy/block-all-mixed-content/resources/red-square.png'), 'rb') as file:

Should use os.path.abspath(...) after os.path.join(...)

> LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.py.json:16
> +]''')

I would do this instead:
print(json.dumps([{
    'action': {'type': 'block-cookies'},
    'trigger': {'url-filter': '8880'},
}], indent=4)

That way you don't have to worry about encoding JSON correctly

> LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies.py.json:16
> +]''')

Ditto on manually encoding json

[Chris Gambrell]

Created attachment 424975 [details]
Patch

[Jonathan Bedard]

Comment on attachment 424975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424975&action=review

> LayoutTests/http/tests/css/resources/webfont-request.py:8
> +file = __file__.split(':/cygwin')[-1]

Doesn't look like we're using this

[Chris Gambrell]

Committed r275427 (236090@main): <https://commits.webkit.org/236090@main>