Replacing PHP with equivalent Python CGI scripts
<rdar://problem/75587716>
Created attachment 423643 [details] Patch
Comment on attachment 423643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423643&action=review > LayoutTests/http/tests/multipart/multipart-html.py:13 > + '{}\n' You used f-strings in another patch, might be a good choice here too > LayoutTests/http/tests/multipart/multipart-replace-non-html-content.py:13 > + '{}\n' Might consider f-string here as well
Created attachment 423925 [details] Patch
(In reply to Jonathan Bedard from comment #3) > Comment on attachment 423643 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423643&action=review > > > LayoutTests/http/tests/multipart/multipart-html.py:13 > > + '{}\n' > > You used f-strings in another patch, might be a good choice here too > > > LayoutTests/http/tests/multipart/multipart-replace-non-html-content.py:13 > > + '{}\n' > > Might consider f-string here as well Fixed in comment 4
Committed r274803: <https://commits.webkit.org/r274803> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423925 [details].
Reopening for second pass
Created attachment 424989 [details] Patch
Comment on attachment 424989 [details] Patch r=me, assuming python works in seconds and php works in microseconds so * 1000000 is no longer needed.
Committed r275424: <https://commits.webkit.org/r275424> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424989 [details].