Bug 223599 - [LayoutTests] Convert http/tests/performance convert PHP to Python
Summary: [LayoutTests] Convert http/tests/performance convert PHP to Python
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Gambrell
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-22 14:05 PDT by Chris Gambrell
Modified: 2021-03-24 12:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2021-03-22 14:07 PDT, Chris Gambrell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gambrell 2021-03-22 14:05:19 PDT 
Replacing PHP with equivalent Python CGI scripts
Comment 1 Radar WebKit Bug Importer 2021-03-22 14:05:42 PDT 
<rdar://problem/75707991>
Comment 2 Chris Gambrell 2021-03-22 14:07:26 PDT 
Created attachment 423935 [details]
Patch
Comment 3 Chris Gambrell 2021-03-22 14:10:56 PDT 
Comment on attachment 423935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423935&action=review

> LayoutTests/http/tests/performance/paint-timing/resources/slowscript.py:8
> +query_string = os.environ.get('QUERY_STRING', '')

Getting the query from the URL like this because url lib.parse.parse_qs separates arguments by ';' as well which creates issues with the 'script' argument being passed
Comment 4 EWS 2021-03-24 12:50:34 PDT 
Committed r274964: <https://commits.webkit.org/r274964>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423935 [details].