Bug 222618 – [LayoutTests] Convert http/tests/download convert PHP to Python

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Gambrell]

Replacing PHP with equivalent Python CGI scripts

[Radar WebKit Bug Importer]

<rdar://problem/74949253>

[Chris Gambrell]

Created attachment 421998 [details]
Patch

[EWS]

Committed r273783: <https://commits.webkit.org/r273783>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421998 [details].

[Chris Gambrell]

Reopening to finish directory:
- LayoutTests/http/tests/download/resources/literal-koi8-r.php
- LayoutTests/http/tests/download/resources/literal-utf-8.php

[Chris Gambrell]

Created attachment 424726 [details]
Patch

[Chris Gambrell]

(In reply to Chris Gambrell from comment #5)
> Created attachment 424726 [details]
> Patch

This patch may have the same issues going through EWS similar to Bug 223522 due to encoding issues

[Alexey Proskuryakov]

Comment on attachment 424726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424726&action=review

> LayoutTests/http/tests/download/resources/literal-utf-8.py:6
> +    'Content-Disposition: attachment; filename=SU{}SS.txt\r\n'

This doesn't look like the same filename?

[Chris Gambrell]

Created attachment 424787 [details]
Patch

[Chris Gambrell]

(In reply to Alexey Proskuryakov from comment #7)
> Comment on attachment 424726 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424726&action=review
> 
> > LayoutTests/http/tests/download/resources/literal-utf-8.py:6
> > +    'Content-Disposition: attachment; filename=SU{}SS.txt\r\n'
> 
> This doesn't look like the same filename?

Moved the encoded parts to their own statement

[Jonathan Bedard]

Comment on attachment 424787 [details]
Patch

Looks good, but let's let EWS chew on it for a bit.

[Chris Gambrell]

(In reply to Jonathan Bedard from comment #10)
> Comment on attachment 424787 [details]
> Patch
> 
> Looks good, but let's let EWS chew on it for a bit.

EWS will be unable to process this patch because of the issue in Bug 223525. Manually committing and bypassing EWS

[Chris Gambrell]

Committed r275295 (235976@main): <https://commits.webkit.org/235976@main>

[Aakash Jain]

(In reply to Chris Gambrell from comment #12)
> Committed r275295 (235976@main): <https://commits.webkit.org/235976@main>
This seems to have broken following tests on mac wk1:

http/tests/download/default-encoding.html
http/tests/download/inherited-encoding-form-submission-result.html
http/tests/download/inherited-encoding.html

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fdownload%2Fdefault-encoding.html&test=http%2Ftests%2Fdownload%2Finherited-encoding-form-submission-result.html&test=http%2Ftests%2Fdownload%2Finherited-encoding.html

[Aakash Jain]

From https://ews-build.s3-us-west-2.amazonaws.com/macOS-Catalina-Release-WK1-Tests-EWS/r424868-4919-clean-tree/http/tests/download/default-encoding-diff.txt
-Policy delegate: resource is an attachment, suggested file name 'SUССЕSS.txt'
+Policy delegate: resource is an attachment, suggested file name 'SU���SS.txt'

[WebKit Commit Bot]

Re-opened since this is blocked by bug 224046

[Chris Gambrell]

Created attachment 424923 [details]
Patch

[Chris Gambrell]

Comment on attachment 424923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424923&action=review

> LayoutTests/http/tests/download/resources/literal-koi8-r.py:5
> +sys.stdout.write('Content-Disposition: attachment; filename=SU\xf3\xf3\xe5SS.txt\r\n'.encode('latin-1').decode('koi8-r', 'replace'))

Decoding as koi8-r now instead of utf-8

[Chris Gambrell]

Committed r275380 (236048@main): <https://commits.webkit.org/236048@main>