Bug 222367 - [LayoutTests] Convert http/tests/fetch convert PHP to Python
Summary: [LayoutTests] Convert http/tests/fetch convert PHP to Python
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Gambrell
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-24 10:36 PST by Chris Gambrell
Modified: 2021-03-01 06:22 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.84 KB, patch)
2021-02-25 06:49 PST, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Patch (6.86 KB, patch)
2021-02-25 10:46 PST, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gambrell 2021-02-24 10:36:57 PST 
Replacing PHP with equivalent Python CGI scripts
Comment 1 Radar WebKit Bug Importer 2021-02-24 10:37:14 PST 
<rdar://problem/74702641>
Comment 2 Chris Gambrell 2021-02-25 06:49:42 PST 
Created attachment 421520 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-25 10:22:06 PST 
Comment on attachment 421520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421520&action=review

> LayoutTests/ChangeLog:5
> +        https://bugs.webkit.org/show_bug.cgi?id=222367

Duplicate bugzilla link here, this should be the radar

> LayoutTests/http/tests/fetch/resources/redirect-with-cache.php:-4
> -    $enableCaching = isset($_SERVER["ENABLECACHING"]) || isset($_GET["enableCaching"]) ? true : false;

Looks like 'enableCaching' can also be sent as a query argument along with as an environment variable
Comment 4 Chris Gambrell 2021-02-25 10:46:06 PST 
Created attachment 421542 [details]
Patch
Comment 5 Chris Gambrell 2021-02-25 10:47:06 PST 
(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 421520 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421520&action=review
> 
> > LayoutTests/ChangeLog:5
> > +        https://bugs.webkit.org/show_bug.cgi?id=222367
> 
> Duplicate bugzilla link here, this should be the radar
> 
> > LayoutTests/http/tests/fetch/resources/redirect-with-cache.php:-4
> > -    $enableCaching = isset($_SERVER["ENABLECACHING"]) || isset($_GET["enableCaching"]) ? true : false;
> 
> Looks like 'enableCaching' can also be sent as a query argument along with
> as an environment variable

Fixed in comment 4
Comment 6 EWS 2021-03-01 06:22:52 PST 
Committed r273648: <https://commits.webkit.org/r273648>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421542 [details].