Bug 222367 – [LayoutTests] Convert http/tests/fetch convert PHP to Python

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Gambrell]

Replacing PHP with equivalent Python CGI scripts

[Radar WebKit Bug Importer]

<rdar://problem/74702641>

[Chris Gambrell]

Created attachment 421520 [details]
Patch

[Jonathan Bedard]

Comment on attachment 421520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421520&action=review

> LayoutTests/ChangeLog:5
> +        https://bugs.webkit.org/show_bug.cgi?id=222367

Duplicate bugzilla link here, this should be the radar

> LayoutTests/http/tests/fetch/resources/redirect-with-cache.php:-4
> -    $enableCaching = isset($_SERVER["ENABLECACHING"]) || isset($_GET["enableCaching"]) ? true : false;

Looks like 'enableCaching' can also be sent as a query argument along with as an environment variable

[Chris Gambrell]

Created attachment 421542 [details]
Patch

[Chris Gambrell]

(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 421520 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421520&action=review
> 
> > LayoutTests/ChangeLog:5
> > +        https://bugs.webkit.org/show_bug.cgi?id=222367
> 
> Duplicate bugzilla link here, this should be the radar
> 
> > LayoutTests/http/tests/fetch/resources/redirect-with-cache.php:-4
> > -    $enableCaching = isset($_SERVER["ENABLECACHING"]) || isset($_GET["enableCaching"]) ? true : false;
> 
> Looks like 'enableCaching' can also be sent as a query argument along with
> as an environment variable

Fixed in comment 4

[EWS]

Committed r273648: <https://commits.webkit.org/r273648>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421542 [details].