Bug 223905 - style checker should warn about adding new PHP files
Summary: style checker should warn about adding new PHP files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-29 14:51 PDT by Ryan Haddad
Modified: 2021-04-15 15:58 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.69 KB, patch)
2021-04-01 11:16 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (5.75 KB, patch)
2021-04-15 15:11 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-03-29 14:51:22 PDT 
Since we are working to convert PHP tests to python, the style checker should warn about adding new PHP files
Comment 1 Radar WebKit Bug Importer 2021-04-01 11:06:37 PDT 
<rdar://problem/76112036>
Comment 2 Jonathan Bedard 2021-04-01 11:16:35 PDT 
Created attachment 424914 [details]
Patch
Comment 3 Jonathan Bedard 2021-04-01 11:17:28 PDT 
The hammer here is a bit bigger than the one requested, but I think it's called for.

This change will warn any time a PHP file is added or modified, but not when one is deleted.
Comment 4 Jonathan Bedard 2021-04-15 15:11:48 PDT 
Created attachment 426140 [details]
Patch for landing
Comment 5 EWS 2021-04-15 15:58:56 PDT 
Committed r276082 (236594@main): <https://commits.webkit.org/236594@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426140 [details].