Bug 139968 – After updating tests to use kerning, ligatures, and printer fonts, some tests fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Myles C. Maxfield]

See TestExpectations.

[Myles C. Maxfield]

See https://bugs.webkit.org/show_bug.cgi?id=139975

[Alexey Proskuryakov]

I filed some individual bugs about tests that became flaky, but there are more. Since they probably share a root cause, I'll start listing them here.

http/tests/misc/acid3.html
https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r177833%20(10985)/http/tests/misc/acid3-diff.txt

[Alexey Proskuryakov]

Landed expectations in r177836.

[Alexey Proskuryakov]

Many of the tests that are marked as failing on Mavericks fail for me when running with ASan on Yosemite. The failures are probably just order dependent.

[Alexey Proskuryakov]

Added more in http://trac.webkit.org/r177919:

+webkit.org/b/139968 [ Mavericks+ ] tables/mozilla/bugs/bug10633.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] tables/mozilla/bugs/bug113235-1.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] tables/mozilla/bugs/bug8858.html [ Pass Failure ]

[Myles C. Maxfield]

For fast/box-decoration-break/box-decoration-break-rendering.html, the line in BreakingContextInlineHeaders.h that says

m_width.addUncommittedWidth(inlineLogicalWidth(m_current.renderer(), true, false));

is returning 2 in one case and 0 in another.

[Myles C. Maxfield]

shouldAddBorderPaddingMargin() gives different answers for a null previous child and a <br> previous child which is a part of box-decoration-break: clone;

[Myles C. Maxfield]

See https://bugs.webkit.org/show_bug.cgi?id=140238

[Eric Carlson]

In r178125, I marked the following as Mavericks+:

css1/box_properties/acid_test.html
css2.1/t09-c5526c-display-00-e.html
css3/selectors3/html/css3-modsel-161.html
css3/selectors3/xhtml/css3-modsel-161.xml
css3/selectors3/xml/css3-modsel-161.xml
fast/block/basic/011.html
fast/block/basic/minheight.html
fast/css/002.html
fast/forms/focus-selection-textarea.html
fast/forms/select-initial-position.html
fast/invalid/008.html
fast/overflow/003.xml
fast/repaint/fixed-move-after-keyboard-scroll.html
fast/replaced/width100percent-textarea.html
fast/text/basic/generic-family-reset.html
fast/text/glyph-reordering.html
fast/text/international/text-combine-image-test.html
media/video-layer-crash.html
scrollbars/overflow-scrollbar-combinations.html
svg/custom/svg-fonts-in-html.html
media/video-layer-crash.html

and added the following:

+webkit.org/b/139968 [ Mavericks+ ] fast/block/margin-collapse/103.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] fast/dom/52776.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] fast/text/complex-text-opacity.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] fast/text/hyphenate-locale.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] fast/text/international/arabic-justify.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] fast/text/international/bidi-AN-after-L.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] fast/text/international/bidi-mirror-he-ar.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] fast/text/international/bidi-neutral-directionality-paragraph-start.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] fast/text/international/bidi-neutral-run.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] platform/mac/fast/text/ligature-subdivision.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] sputnik/Unicode/Unicode_510/S7.6_A3.1.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] sputnik/Unicode/Unicode_510/S7.6_A3.2.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] sputnik/Unicode/Unicode_510/S7.6_A5.3_T1.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] svg/W3C-SVG-1.1-SE/text-intro-05-t.svg [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] svg/W3C-SVG-1.1/text-intro-05-t.svg [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] svg/text/text-intro-05-t.svg [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] tables/mozilla/bugs/bug2479-2.html [ Pass Failure ]

[Eric Carlson]

Add more in https://trac.webkit.org/r178210 :

+webkit.org/b/139968 [ Mavericks+ ] media/controls-after-reload.html [ Pass Failure ]
+webkit.org/b/139968 [ Mavericks+ ] media/controls-without-preload.html [ Pass Failure ]

[Myles C. Maxfield]

I've found at least one consistent reproduction on shipping Yosemite by running editing/selection/move-by-character-brute-force.html, even after applying the workaround in https://bugs.webkit.org/show_bug.cgi?id=140253

[Myles C. Maxfield]

(That one test is tables/mozilla/bugs/bug10633.html)

[Myles C. Maxfield]

(In reply to comment #9)
> In r178125, I marked the following as Mavericks+:
> 
> css1/box_properties/acid_test.html
> css2.1/t09-c5526c-display-00-e.html
> css3/selectors3/html/css3-modsel-161.html
> css3/selectors3/xhtml/css3-modsel-161.xml
> css3/selectors3/xml/css3-modsel-161.xml
> fast/block/basic/011.html
> fast/block/basic/minheight.html
> fast/css/002.html
> fast/forms/focus-selection-textarea.html
> fast/forms/select-initial-position.html
> fast/invalid/008.html
> fast/overflow/003.xml
> fast/repaint/fixed-move-after-keyboard-scroll.html
> fast/replaced/width100percent-textarea.html
> fast/text/basic/generic-family-reset.html
> fast/text/glyph-reordering.html
> fast/text/international/text-combine-image-test.html
> media/video-layer-crash.html
> scrollbars/overflow-scrollbar-combinations.html
> svg/custom/svg-fonts-in-html.html
> media/video-layer-crash.html
> 
> and added the following:
> 
> +webkit.org/b/139968 [ Mavericks+ ] fast/block/margin-collapse/103.html [
> Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ] fast/dom/52776.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ] fast/text/complex-text-opacity.html [
> Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ] fast/text/hyphenate-locale.html [ Pass
> Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> fast/text/international/arabic-justify.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> fast/text/international/bidi-AN-after-L.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> fast/text/international/bidi-mirror-he-ar.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> fast/text/international/bidi-neutral-directionality-paragraph-start.html [
> Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> fast/text/international/bidi-neutral-run.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> platform/mac/fast/text/ligature-subdivision.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> sputnik/Unicode/Unicode_510/S7.6_A3.1.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> sputnik/Unicode/Unicode_510/S7.6_A3.2.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> sputnik/Unicode/Unicode_510/S7.6_A5.3_T1.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ]
> sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html [ Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ] svg/W3C-SVG-1.1-SE/text-intro-05-t.svg [
> Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ] svg/W3C-SVG-1.1/text-intro-05-t.svg [
> Pass Failure ]
> +webkit.org/b/139968 [ Mavericks+ ] svg/text/text-intro-05-t.svg [ Pass
> Failure ]
> +webkit.org/b/139968 [ Mavericks+ ] tables/mozilla/bugs/bug2479-2.html [
> Pass Failure ]

Eric: The flakiness dashboard isn't showing any of these tests as flakey on Mavericks+. Why did you add them? Can I remove them?

[Myles C. Maxfield]

(In reply to comment #10)
> Add more in https://trac.webkit.org/r178210 :
> 
> +webkit.org/b/139968 [ Mavericks+ ] media/controls-after-reload.html [ Pass
> Failure ]
> +webkit.org/b/139968 [ Mavericks+ ] media/controls-without-preload.html [
> Pass Failure ]

These too.

[Myles C. Maxfield]

Committed r181260: <http://trac.webkit.org/changeset/181260>

[Jonathan Bedard]

Updated test expectation in <http://trac.webkit.org/changeset/217761>