Bug 141685 - Update expected result of fast/forms/text-control-intrinsic-widths.html after r177774
Summary: Update expected result of fast/forms/text-control-intrinsic-widths.html after...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 139968
  Show dependency treegraph
 
Reported: 2015-02-16 17:51 PST by Myles C. Maxfield
Modified: 2015-02-20 14:59 PST (History)
8 users (show)

See Also:


Attachments
Patch (7.00 KB, patch)
2015-02-16 17:51 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (673.29 KB, application/zip)
2015-02-16 18:28 PST, Build Bot
no flags Details
Archive of layout-test-results from ews103 for mac-mavericks (527.33 KB, application/zip)
2015-02-16 18:39 PST, Build Bot
no flags Details
Patch (15.49 KB, patch)
2015-02-17 21:21 PST, Myles C. Maxfield
ap: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-02-16 17:51:12 PST
Update expected result of fast/forms/text-control-intrinsic-widths.html after r177774
Comment 1 Myles C. Maxfield 2015-02-16 17:51:42 PST
Created attachment 246709 [details]
Patch
Comment 2 Build Bot 2015-02-16 18:27:56 PST
Comment on attachment 246709 [details]
Patch

Attachment 246709 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6077909110358016

New failing tests:
fast/forms/text-control-intrinsic-widths.html
Comment 3 Build Bot 2015-02-16 18:28:00 PST
Created attachment 246712 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-02-16 18:39:13 PST
Comment on attachment 246709 [details]
Patch

Attachment 246709 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6684858856243200

New failing tests:
fast/forms/text-control-intrinsic-widths.html
Comment 5 Build Bot 2015-02-16 18:39:16 PST
Created attachment 246715 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Myles C. Maxfield 2015-02-17 21:21:22 PST
Created attachment 246798 [details]
Patch
Comment 7 WebKit Commit Bot 2015-02-18 15:51:08 PST
Comment on attachment 246798 [details]
Patch

Rejecting attachment 246798 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 246798, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/mac-mavericks/fast/forms/text-control-intrinsic-widths-expected.txt
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1265.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej
patching file LayoutTests/platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6697096291811328
Comment 8 Myles C. Maxfield 2015-02-18 15:59:27 PST
Committed r180321: <http://trac.webkit.org/changeset/180321>
Comment 9 Alexey Proskuryakov 2015-02-18 20:20:12 PST
This test is now failing on Yosemite:

 Verdana
 input
-size=1 clientWidth=24
-size=2 clientWidth=30
-size=3 clientWidth=36
-size=4 clientWidth=42
-size=5 clientWidth=48
-size=10 clientWidth=78
-size=20 clientWidth=138
-size=50 clientWidth=318
-size=100 clientWidth=618
-size=500 clientWidth=3018
-size=1000 clientWidth=6018
+size=1 clientWidth=23
+size=2 clientWidth=29
+size=3 clientWidth=35
+size=4 clientWidth=41
+size=5 clientWidth=47
+size=10 clientWidth=77
+size=20 clientWidth=137
+size=50 clientWidth=317
+size=100 clientWidth=617
+size=500 clientWidth=3017
+size=1000 clientWidth=6017
Comment 10 Alexey Proskuryakov 2015-02-18 20:25:15 PST
I updated Yosemite results again in r180335.

Where did the results you landed come from? I simply took the result from a bot, but I'm now concerned that it may not match what happens locally.
Comment 11 Myles C. Maxfield 2015-02-19 06:43:32 PST
(In reply to comment #10)
> I updated Yosemite results again in r180335.
> 
> Where did the results you landed come from? I simply took the result from a
> bot, but I'm now concerned that it may not match what happens locally.

Thanks, Alexey. You are right - that expected result is what I ran locally. There is some difference between the bots and my local machine.
Comment 12 Myles C. Maxfield 2015-02-19 14:59:14 PST
I can't reproduce the bot's results on my local machine, even when running the tests in the same order as it.
Comment 13 Myles C. Maxfield 2015-02-20 08:30:47 PST
Running shipping Yosemite, my machine agrees with the bots.
Comment 14 Myles C. Maxfield 2015-02-20 14:59:54 PST
This is because my machine has MS Office fonts installed, and CT uses these fonts preferentially over the system fonts. Verdana is one of these fonts.