Bug 141603 - Update expected result for editing/pasteboard/5761530-1.html after r177774
Summary: Update expected result for editing/pasteboard/5761530-1.html after r177774
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 139968
  Show dependency treegraph
 
Reported: 2015-02-14 09:50 PST by Myles C. Maxfield
Modified: 2015-02-16 13:58 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.60 KB, patch)
2015-02-14 09:51 PST, Myles C. Maxfield
ap: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-02-14 09:50:12 PST
Update expected result for editing/pasteboard/5761530-1.html after r177774
Comment 1 Myles C. Maxfield 2015-02-14 09:51:26 PST
Created attachment 246595 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-02-16 10:21:03 PST
Comment on attachment 246595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246595&action=review

rs=me

> LayoutTests/ChangeLog:8
> +        The test used to have incorrect expected output, but the new results are correct.

How did changing rendering fix the pasteboard?!
Comment 3 Myles C. Maxfield 2015-02-16 13:54:12 PST
(In reply to comment #2)
> Comment on attachment 246595 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246595&action=review
> 
> rs=me
> 
> > LayoutTests/ChangeLog:8
> > +        The test used to have incorrect expected output, but the new results are correct.
> 
> How did changing rendering fix the pasteboard?!

I'm not sure. However, I've verified that the results we are getting now are correct. I don't think it's worth really digging in here because of all the tests I have yet to go through. Marking as cq+.
Comment 4 WebKit Commit Bot 2015-02-16 13:56:05 PST
Comment on attachment 246595 [details]
Patch

Rejecting attachment 246595 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 246595, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
s from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/editing/pasteboard/5761530-1-expected.txt
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1266.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4968121773326336
Comment 5 Myles C. Maxfield 2015-02-16 13:58:43 PST
Committed r180172: <http://trac.webkit.org/changeset/180172>