WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
141590
[Mac] Cleanup after
r177774
https://bugs.webkit.org/show_bug.cgi?id=141590
Summary
[Mac] Cleanup after r177774
Myles C. Maxfield
Reported
2015-02-13 20:12:10 PST
[Mac] Cleanup after
r177774
Attachments
Patch
(421.07 KB, patch)
2015-02-13 20:28 PST
,
Myles C. Maxfield
zalan
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews103 for mac-mavericks
(573.83 KB, application/zip)
2015-02-13 21:15 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2
(726.77 KB, application/zip)
2015-02-13 21:20 PST
,
Build Bot
no flags
Details
Patch for landing
(417.73 KB, patch)
2015-02-13 21:43 PST
,
Myles C. Maxfield
ap
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2015-02-13 20:28:11 PST
Created
attachment 246573
[details]
Patch
zalan
Comment 2
2015-02-13 20:36:19 PST
Comment on
attachment 246573
[details]
Patch rs=me
Myles C. Maxfield
Comment 3
2015-02-13 20:46:50 PST
Comment on
attachment 246573
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=246573&action=review
> LayoutTests/ChangeLog:12 > + * platform/mac/accessibility/press-targets-center-point-expected.txt: Added.
No it wasn't
Build Bot
Comment 4
2015-02-13 21:15:53 PST
Comment on
attachment 246573
[details]
Patch
Attachment 246573
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/5301703293272064
New failing tests: fast/repaint/fixed-move-after-keyboard-scroll.html
Build Bot
Comment 5
2015-02-13 21:15:58 PST
Created
attachment 246576
[details]
Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 6
2015-02-13 21:20:34 PST
Comment on
attachment 246573
[details]
Patch
Attachment 246573
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/4972647595114496
New failing tests: fast/repaint/fixed-move-after-keyboard-scroll.html
Build Bot
Comment 7
2015-02-13 21:20:37 PST
Created
attachment 246577
[details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Myles C. Maxfield
Comment 8
2015-02-13 21:43:12 PST
Created
attachment 246579
[details]
Patch for landing
Alexey Proskuryakov
Comment 9
2015-02-13 22:31:15 PST
Comment on
attachment 246579
[details]
Patch for landing View in context:
https://bugs.webkit.org/attachment.cgi?id=246579&action=review
rs=me
> LayoutTests/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:24 > - (bounds 216.00 15.00) > + (bounds 211.00 15.00)
It's strange that we have any results of this kind in root expectations, how can they be cross-platform? What's the policy here?
Myles C. Maxfield
Comment 10
2015-02-14 07:51:23 PST
I'm not sure. I can only guess that all the other platforms skip these tests. Perhaps I should make a subsequent patch that moves these results into platform/mac... (In reply to
comment #9
)
> Comment on
attachment 246579
[details]
> Patch for landing > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=246579&action=review
> > rs=me > > > LayoutTests/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:24 > > - (bounds 216.00 15.00) > > + (bounds 211.00 15.00) > > It's strange that we have any results of this kind in root expectations, how > can they be cross-platform? What's the policy here?
WebKit Commit Bot
Comment 11
2015-02-14 07:53:40 PST
Comment on
attachment 246579
[details]
Patch for landing Rejecting
attachment 246579
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 246579, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g/filters/filter-on-tspan-expected.txt patching file LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.txt patching file LayoutTests/platform/mac/tables/mozilla/bugs/
bug131020
-expected.txt patching file LayoutTests/svg/filters/feColorMatrix-values-expected.txt patching file LayoutTests/svg/repaint/text-mask-update-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.appspot.com/results/4862650261438464
Myles C. Maxfield
Comment 12
2015-02-14 08:01:51 PST
Committed
r180107
: <
http://trac.webkit.org/changeset/180107
>
Alexey Proskuryakov
Comment 13
2015-02-14 10:53:20 PST
fast/repaint/fixed-move-after-keyboard-scroll.html isn't doing well on bots:
https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Frepaint%2Ffixed-move-after-keyboard-scroll.html
This change fixed it on Yosemite WebKit1 based testers, broke it on Windows, and it remains broken on all other testers. I'll add an expectation now.
Alexey Proskuryakov
Comment 14
2015-02-14 10:56:05 PST
Given that EWS approved of the patch, the test must be flaky on Mavericks; possibly order dependent. It seems that figuring out why some tests are order dependent may need to happen before updating expectations; otherwise we may keep updating results to something that bots happen to show at the moment, but with is not guaranteed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug