Bug 141679 - Update cross-frame http tests after r177774
Summary: Update cross-frame http tests after r177774
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 139968
  Show dependency tree / graph
 
Reported: 2015-02-16 16:40 PST by Myles C. Maxfield
Modified: 2015-02-16 18:21 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2015-02-16 16:41 PST, Myles C. Maxfield 		ap: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-02-16 16:40:49 PST 
Update cross-frame http tests after r177774
Comment 1 Myles C. Maxfield 2015-02-16 16:41:44 PST 
Created attachment 246702 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-02-16 17:28:42 PST 
Comment on attachment 246702 [details]
Patch

I don't see how r177774 could possibly affect this. It may be worth digging deeper.

That said, flakiness with spaces that correspond to iframe and object elements is somewhat common on tests, I think that it's a bug in line layout code, where it produces different results depending on whether layout happens before or after a newline after the element is parsed. As such, this is probably OK to land.
Comment 3 Myles C. Maxfield 2015-02-16 17:31:11 PST 
https://bugs.webkit.org/show_bug.cgi?id=141681
Comment 4 WebKit Commit Bot 2015-02-16 18:15:06 PST 
Comment on attachment 246702 [details]
Patch

Rejecting attachment 246702 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 246702, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 180195 = 25e4353fede138ac39388c7aeaea2fd0986a38e3
r180197 = ade3d778dcc2af6eca1825eb7d846e2feeb6f8e7
r180200 = a9bfab5ed24fe57aa74ab2510808f9a553d95f14
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/4752338422071296
Comment 5 Myles C. Maxfield 2015-02-16 18:21:19 PST 
Committed r180202: <http://trac.webkit.org/changeset/180202>