RESOLVED FIXED138025
[Win] Some tests fail after removing SafariTheme because text containing elements are too large (potentially due to larger font sizes) 
https://bugs.webkit.org/show_bug.cgi?id=138025
Summary [Win] Some tests fail after removing SafariTheme because text containing elem...
Roger Fong
Reported 2014-10-23 15:19:16 PDT
This may have something to do with the incorrect font sizes within the buttons/textareas. editing/input/caret-at-the-edge-of-input.html editing/inserting/4960120-1.html fast/css/resize-corner-tracking.html fast/css/text-overflow-input.html fast/dynamic/008.html fast/frames/take-focus-from-iframe.html fast/overflow/overflow-x-y.html fast/parser/entity-comment-in-textarea.html fast/parser/open-comment-in-textarea.html fast/table/003.html fast/table/colspanMinWidth-vertical.html fast/table/colspanMinWidth.html fast/text/international/unicode-bidi-plaintext-in-textarea.html tables/mozilla/bugs/bug103533.html tables/mozilla/bugs/bug12384.html tables/mozilla/bugs/bug26178.html tables/mozilla/bugs/bug28928.html tables/mozilla/bugs/bug30559.html tables/mozilla/bugs/bug30692.html tables/mozilla/bugs/bug4429.html tables/mozilla/bugs/bug44505.html tables/mozilla/bugs/bug51037.html tables/mozilla/bugs/bug55545.html tables/mozilla/bugs/bug92647-2.html tables/mozilla/bugs/bug99948.html tables/mozilla/other/move_row.html tables/mozilla_expected_failures/bugs/bug1725.html tables/mozilla_expected_failures/bugs/bug2479-5.html tables/mozilla_expected_failures/bugs/bug45621.html tables/mozilla_expected_failures/bugs/bug58402-2.html transitions/3d/interrupted-transition.html fast/selectors/064.html fast/replaced/width100percent-textfield.html fast/replaced/width100percent-textarea.html fast/replaced/width100percent-searchfield.html fast/replaced/width100percent-menulist.html fast/replaced/width100percent-checkbox.html I will be skipping all of these.
Attachments
Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2014-10-23 15:26:32 PDT
Someone already got to it. oops
Roger Fong
Comment 2 2014-10-23 15:38:49 PDT
JK
Roger Fong
Comment 3 2014-10-23 16:07:41 PDT
Skipped: https://trac.webkit.org/changeset/175146
Roger Fong
Comment 4 2014-10-24 01:46:47 PDT
The actual reason behind this may be larger text and as a result, larger elements containing said text (as compared to Mac port) Many of these may also be wrong due to form element differences in theme (i.e rounded vs. square buttons) More to the skip list: fast/css/css2-system-fonts.html [ Failure ] fast/css/line-height.html [ Failure ] fast/css/negative-text-indent-in-inline-block.html [ Failure ] fast/dom/HTMLInputElement/input-image-alt-text.html [ Failure ] fast/dom/HTMLTableColElement/resize-table-using-col-width.html [ Failure ] fast/forms/search/search-size-with-decorations.html [ Failure ] fast/forms/HTMLOptionElement_label07.html [ Failure ] fast/forms/select/optgroup-rendering.html [ Timeout ] fast/overflow/scroll-nested-positioned-layer-in-overflow.html [ Failure ] fast/overflow/scrollRevealButton.html [ Failure ] fast/repaint/control-clip.html [ Failure ] svg/custom/inline-svg-in-xhtml.xml [ Failure ]
Roger Fong
Comment 5 2014-10-24 01:51:49 PDT
Round 2 of skipping: http://trac.webkit.org/changeset/175162
Brent Fulgham
Comment 6 2015-01-24 11:06:23 PST
I think these should just be rebaselined, since these are the font metrics for the platform.
Brent Fulgham
Comment 7 2015-01-25 10:10:37 PST
Rebaselined: CSS baselines: <https://trac.webkit.org/changeset/179082> Fast baselines: <https://trac.webkit.org/changeset/179083> Tables baselines: <https://trac.webkit.org/changeset/179084>
Note You need to log in before you can comment on or make changes to this bug.