Bug 103533 - Adding Nima Ghanavatian to committers.py
Summary: Adding Nima Ghanavatian to committers.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 09:23 PST by Nima Ghanavatian
Modified: 2012-11-28 15:55 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2012-11-28 09:28 PST, Nima Ghanavatian 		rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-11-28 09:23:25 PST 
SSIA
Comment 1 Nima Ghanavatian 2012-11-28 09:28:03 PST 
Created attachment 176496 [details]
Patch
Comment 2 Rob Buis 2012-11-28 09:29:51 PST 
Comment on attachment 176496 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-11-28 10:36:34 PST 
Comment on attachment 176496 [details]
Patch

Rejecting attachment 176496 [details] from commit-queue.

nima.ghanavatian@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 Rob Buis 2012-11-28 15:55:55 PST 
Fixed with r136067.