Bug 30559 - [v8] Set debug id for contexts of isolated worlds
Summary: [v8] Set debug id for contexts of isolated worlds
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-10-20 03:08 PDT by Yury Semikhatsky
Modified: 2009-10-20 12:11 PDT (History)
1 user (show)

See Also:

patch (3.47 KB, patch)
2009-10-20 03:38 PDT, Yury Semikhatsky
pfeldman: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2009-10-20 03:08:19 PDT
V8Proxy provides debug data for frame context and for contexts created in V8Proxy::evaluateInNewContext but the data are not set for isolated worlds. This makes user scripts indistinguishable from scripts in the utility context and as such they are filtered out in JS debugger in Chromium DevTools.
Comment 1 Yury Semikhatsky 2009-10-20 03:38:15 PDT
Created attachment 41495 [details]
Comment 2 WebKit Commit Bot 2009-10-20 06:55:45 PDT
Comment on attachment 41495 [details]

Rejecting patch 41495 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 60
Last 500 characters of output:
ages while\n\trunning as root.  There are known race conditions that\n\twill allow any local user to read any file on the system.\n\tIf you still desire to serve pages as root then\n\tadd -DBIG_SECURITY_HOLE to the CFLAGS env variable\n\tand then rebuild the server.\n\tIt is strongly suggested that you instead modify the User\n\tdirective in your httpd.conf file to list a non-root\n\tuser.\n
Timed out waiting for httpd to start at WebKitTools/Scripts/run-webkit-tests line 1359, <IN> line 30183.
Comment 3 Yury Semikhatsky 2009-10-20 08:07:33 PDT
Password for 'yurys@chromium.org': 
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/v8/V8Proxy.cpp
Sending        WebCore/bindings/v8/V8Proxy.h
Transmitting file data ...
Committed revision 49856.
Comment 4 Eric Seidel (no email) 2009-10-20 12:11:56 PDT
Comment on attachment 41495 [details]

Sorry about the commit-queue troubles.