Bug 51037 - [Qt] Avoid GraphicsContext save/restore in Image::drawPattern()
Summary: [Qt] Avoid GraphicsContext save/restore in Image::drawPattern()
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andreas Kling
Keywords: Performance, Qt, QtTriaged
Depends on:
Reported: 2010-12-14 07:25 PST by Andreas Kling
Modified: 2010-12-14 09:49 PST (History)
1 user (show)

See Also:

Proposed patch (1.51 KB, patch)
2010-12-14 07:47 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-12-14 07:25:38 PST
It's enough to restore the CompositeOperator after drawing.
Comment 1 Andreas Kling 2010-12-14 07:47:06 PST
Created attachment 76535 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-12-14 08:12:36 PST
Comment on attachment 76535 [details]
Proposed patch

I trust you on this! :-)
Comment 3 WebKit Commit Bot 2010-12-14 09:11:46 PST
The commit-queue encountered the following flaky tests while processing attachment 76535 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org)
fast/history/history-subframe-with-name.html bug 51039 (author: mihaip@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-14 09:49:18 PST
Comment on attachment 76535 [details]
Proposed patch

Clearing flags on attachment: 76535

Committed r74035: <http://trac.webkit.org/changeset/74035>
Comment 5 WebKit Commit Bot 2010-12-14 09:49:23 PST
All reviewed patches have been landed.  Closing bug.