WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30692
Incorrect pixel result for test svg-as-background-6
https://bugs.webkit.org/show_bug.cgi?id=30692
Summary
Incorrect pixel result for test svg-as-background-6
Victor Wang
Reported
2009-10-22 14:56:43 PDT
The old pixel results of svg-as-background-6 is incorrect because of the wrong SVG Masking offset calculation. The issue was fixed by patch:
http://trac.webkit.org/changeset/49598
Needs to update the expected pixel result for this test.
Attachments
Proposed Patch
(101.06 KB, patch)
2009-10-22 15:00 PDT
,
Victor Wang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Victor Wang
Comment 1
2009-10-22 15:00:34 PDT
Created
attachment 41687
[details]
Proposed Patch
Eric Seidel (no email)
Comment 2
2009-10-23 11:39:53 PDT
Comment on
attachment 41687
[details]
Proposed Patch We really should change this test not to use red as a backup color. Red generally means fail, but I believe this SVG is supposed to be transparent so red is correct.
Victor Wang
Comment 3
2009-10-23 11:53:04 PDT
Eric, Thanks for reviewing this, could you add the patch to commit-queue? Thanks!
Eric Seidel (no email)
Comment 4
2009-10-23 12:08:04 PDT
Comment on
attachment 41687
[details]
Proposed Patch Sure thing. You can always set commit-queue? on your patches to request that folks add them to the commit-queue for you.
WebKit Commit Bot
Comment 5
2009-10-23 13:06:07 PDT
Comment on
attachment 41687
[details]
Proposed Patch Clearing flags on attachment: 41687 Committed
r49991
: <
http://trac.webkit.org/changeset/49991
>
WebKit Commit Bot
Comment 6
2009-10-23 13:06:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug