Bug 30692 - Incorrect pixel result for test svg-as-background-6
Summary: Incorrect pixel result for test svg-as-background-6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-22 14:56 PDT by Victor Wang
Modified: 2009-10-23 13:06 PDT (History)
3 users (show)

See Also:

Attachments
Proposed Patch (101.06 KB, patch)
2009-10-22 15:00 PDT, Victor Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2009-10-22 14:56:43 PDT 
The old pixel results of svg-as-background-6 is incorrect because of the wrong SVG Masking offset calculation. The issue was fixed by patch: http://trac.webkit.org/changeset/49598
Needs to update the expected pixel result for this test.
Comment 1 Victor Wang 2009-10-22 15:00:34 PDT 
Created attachment 41687 [details]
Proposed Patch
Comment 2 Eric Seidel (no email) 2009-10-23 11:39:53 PDT 
Comment on attachment 41687 [details]
Proposed Patch

We really should change this test not to use red as a backup color.  Red generally means fail, but I believe this SVG is supposed to be transparent so red is correct.
Comment 3 Victor Wang 2009-10-23 11:53:04 PDT 
Eric,
Thanks for reviewing this, could you add the patch to commit-queue? Thanks!
Comment 4 Eric Seidel (no email) 2009-10-23 12:08:04 PDT 
Comment on attachment 41687 [details]
Proposed Patch

Sure thing.  You can always set commit-queue? on your patches to request that folks add them to the commit-queue for you.
Comment 5 WebKit Commit Bot 2009-10-23 13:06:07 PDT 
Comment on attachment 41687 [details]
Proposed Patch

Clearing flags on attachment: 41687

Committed r49991: <http://trac.webkit.org/changeset/49991>
Comment 6 WebKit Commit Bot 2009-10-23 13:06:12 PDT 
All reviewed patches have been landed.  Closing bug.