Bug 137424 - Add is<>() / downcast<>() support for RenderObject subclasses
Summary: Add is<>() / downcast<>() support for RenderObject subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks: 137476 137512 137545 137587 137594 137622 137641 137683 137696 137704 137727 137733 137749 137764 137766 137768 137804 137824 137840 137845
  Show dependency tree / graph
 
Reported: 2014-10-04 14:58 PDT by Chris Dumez
Modified: 2014-10-17 21:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (81.34 KB, patch)
2014-10-04 17:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (84.85 KB, patch)
2014-10-04 20:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (84.85 KB, patch)
2014-10-06 16:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-04 14:58:07 PDT 
Add is<>() / downcast<>() support for RenderObject subclasses
Comment 1 Chris Dumez 2014-10-04 17:11:54 PDT 
Created attachment 239287 [details]
Patch
Comment 2 Chris Dumez 2014-10-04 20:30:30 PDT 
Created attachment 239289 [details]
Patch
Comment 3 Benjamin Poulain 2014-10-06 16:00:46 PDT 
Comment on attachment 239289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239289&action=review

lgtm.

> Source/WebCore/rendering/RenderIterator.h:76
> +// Similar to WTF::is<>() but without the static_assert() making sure
> +// the check is necessary.

One line.

> Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:157
> +            if (parentBlock.isRenderMathMLScriptsWrapper()) {

No is<RenderMathMLScriptsWrapper>?
Comment 4 Chris Dumez 2014-10-06 16:43:47 PDT 
Created attachment 239366 [details]
Patch
Comment 5 WebKit Commit Bot 2014-10-06 17:26:29 PDT 
Comment on attachment 239366 [details]
Patch

Clearing flags on attachment: 239366

Committed r174375: <http://trac.webkit.org/changeset/174375>
Comment 6 WebKit Commit Bot 2014-10-06 17:26:34 PDT 
All reviewed patches have been landed.  Closing bug.