RESOLVED FIXED 137727
Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine 
https://bugs.webkit.org/show_bug.cgi?id=137727
Summary Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine
Chris Dumez
Reported 2014-10-14 18:56:24 PDT
Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine.
Attachments
Patch (16.73 KB, patch)
2014-10-14 19:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (16.68 KB, patch)
2014-10-15 10:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-14 19:00:21 PDT
Created attachment 239838 [details] Patch
Darin Adler
Comment 2 2014-10-15 09:18:23 PDT
Comment on attachment 239838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239838&action=review > Source/WebCore/page/EventHandler.cpp:3696 > + if (auto* renderer = element->renderer()) { > + if (is<RenderTextControlSingleLine>(renderer)) Should either use *renderer here, or eliminate the if that checks renderer for null.
Chris Dumez
Comment 3 2014-10-15 10:16:55 PDT
Created attachment 239875 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-15 10:36:43 PDT
Comment on attachment 239875 [details] Patch Clearing flags on attachment: 239875 Committed r174732: <http://trac.webkit.org/changeset/174732>
WebKit Commit Bot
Comment 5 2014-10-15 10:36:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.