Bug 137733 – Use is<>() / downcast<>() for ClipPathOperation subclasses

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Chris Dumez]

Use is<>() / downcast<>() for ClipPathOperation subclasses

[Chris Dumez]

Created attachment 239845 [details]
Patch

[Mihnea Ovidenie]

Comment on attachment 239845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239845&action=review

r=me with some comments.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2856
> +                ReferenceClipPathOperation& referenceOperation = downcast<ReferenceClipPathOperation>(*operation);

I guess you can use const auto& referenceOperation instead.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2861
> +                ShapeClipPathOperation& shapeOperation = downcast<ShapeClipPathOperation>(*operation);

ShapeClipPathOperation& shapeOperation -> const auto& shapeOperation

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2867
> +                BoxClipPathOperation& boxOperation = downcast<BoxClipPathOperation>(*operation);

BoxClipPathOperation& boxOperation -> const auto& boxOperation

> Source/WebCore/rendering/RenderBlock.cpp:2456
> +            ShapeClipPathOperation& clipPath = downcast<ShapeClipPathOperation>(*style().clipPath());

ShapeClipPathOperation& clipPath -> const auto& clipPath

> Source/WebCore/rendering/RenderLayer.cpp:3929
> +        ShapeClipPathOperation& clippingPath = downcast<ShapeClipPathOperation>(*style.clipPath());

ShapeClipPathOperation& clippingPath -> const auto& clipPath. I noticed that in general we use clipPath and I think we should use clipPath here too (and for the same reason below).

> Source/WebCore/rendering/RenderLayer.cpp:3938
> +        BoxClipPathOperation& clippingPath = downcast<BoxClipPathOperation>(*style.clipPath());

BoxClipPathOperation& clippingPath -> const auto& clipPath

> Source/WebCore/rendering/svg/SVGRenderingContext.cpp:140
> +        ShapeClipPathOperation& clipPath = downcast<ShapeClipPathOperation>(*clipPathOperation);

ShapeClipPathOperation& clipPath -> const auto& clipPath

[Chris Dumez]

Created attachment 239874 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 239874 [details]
Patch

Clearing flags on attachment: 239874

Committed r174729: <http://trac.webkit.org/changeset/174729>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.