Use is<>() / downcast<>() for RenderElement
Created attachment 239644 [details] Patch
Created attachment 239645 [details] Patch
Created attachment 239647 [details] Patch
Comment on attachment 239647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239647&action=review > Source/WebCore/rendering/RenderCounter.cpp:624 > + counterName ? WebCore::counterMaps().get(downcast<WebCore::RenderElement>(current))->get(identifier) : (WebCore::CounterNode*)1 : (WebCore::CounterNode*)0); What the heck! > Source/WebCore/rendering/svg/SVGRenderSupport.cpp:263 > + downcast<RenderSVGText>(*child).setNeedsTextMetricsUpdate(); > + downcast<RenderSVGText>(*child).setNeedsPositioningValuesUpdate(); IMHO, it would be cleaner to put downcast<RenderSVGText>(*child) in a temporary here.
Created attachment 239654 [details] Patch
Comment on attachment 239654 [details] Patch Clearing flags on attachment: 239654 Committed r174619: <http://trac.webkit.org/changeset/174619>
All reviewed patches have been landed. Closing bug.