Bug 137840 - Use is<>() / downcast<>() for all SVG RenderObjects
Summary: Use is<>() / downcast<>() for all SVG RenderObjects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137424
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-17 16:14 PDT by Chris Dumez
Modified: 2014-10-17 17:21 PDT (History)
22 users (show)

See Also:


Attachments
Patch (32.98 KB, patch)
2014-10-17 16:18 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-17 16:14:35 PDT
Use is<>() / downcast<>() for all SVG RenderObjects
Comment 1 Chris Dumez 2014-10-17 16:18:04 PDT
Created attachment 240050 [details]
Patch
Comment 2 Benjamin Poulain 2014-10-17 16:41:13 PDT
Comment on attachment 240050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240050&action=review

> Source/WebCore/rendering/RenderLayerFilterInfo.cpp:131
> +    for (const auto& filter : m_internalSVGReferences) {

Shouldn't this be const auto*?

> Source/WebCore/rendering/svg/SVGRootInlineBox.cpp:-80
> -    RenderSVGText* textRoot = toRenderSVGText(&blockFlow());
> -    ASSERT(textRoot);

ahahahahah
Comment 3 Chris Dumez 2014-10-17 16:43:44 PDT
Comment on attachment 240050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240050&action=review

>> Source/WebCore/rendering/RenderLayerFilterInfo.cpp:131
>> +    for (const auto& filter : m_internalSVGReferences) {
> 
> Shouldn't this be const auto*?

It is a RefPtr type.
Comment 4 WebKit Commit Bot 2014-10-17 17:21:45 PDT
Comment on attachment 240050 [details]
Patch

Clearing flags on attachment: 240050

Committed r174854: <http://trac.webkit.org/changeset/174854>
Comment 5 WebKit Commit Bot 2014-10-17 17:21:55 PDT
All reviewed patches have been landed.  Closing bug.