Bug 137704 – Use is<>() / downcast<>() for RenderInline

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Chris Dumez]

Use is<>() / downcast<>() for RenderInline.

[Chris Dumez]

Created attachment 239812 [details]
Patch

[WebKit Commit Bot]

Attachment 239812 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderInline.cpp:1111:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 239812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239812&action=review

> Source/WebCore/rendering/InlineFlowBox.cpp:222
> -    toRenderInline(renderer()).lineBoxes().removeLineBox(this);
> +    downcast<RenderInline>(renderer()).lineBoxes().removeLineBox(this);

Seems like renderer() should return a RenderInline& if it’s guaranteed to be one. Maybe there’s some reason not to do this.

> Source/WebCore/rendering/InlineFlowBox.cpp:1011
> +    for (InlineBox* current = lastChild(); current; current = current->prevOnLine()) {

I think I would have called this “child” instead of “current”. I noticed one like this in a previous patch, and probably should have commented then.

> Source/WebCore/rendering/RenderBox.cpp:2013
> +    ASSERT(renderer == container() || is<RenderRegion>(*renderer));

Looks like this function should take a RenderElement& given that assertion. Maybe some day we can make that change.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:217
> +    while (is<RenderInline>(parent)) {

This would read better as a for loop. If we can’t fit it all on one line we could leave out the initializer, but the termination and “move to parent” would be fit nicely in a for.

[Chris Dumez]

Created attachment 239832 [details]
Patch

[WebKit Commit Bot]

Attachment 239832 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderInline.cpp:1111:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 239832 [details]
Patch

Clearing flags on attachment: 239832

Committed r174714: <http://trac.webkit.org/changeset/174714>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.