Bug 137824 – Use is<>() / downcast<>() for StyleImage

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Chris Dumez]

Use is<>() / downcast<>() for StyleImage.

[Chris Dumez]

Created attachment 240021 [details]
Patch

[Chris Dumez]

Created attachment 240027 [details]
Patch

[Andreas Kling]

Comment on attachment 240027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240027&action=review

r=me

> Source/WebCore/css/CSSCursorImageValue.cpp:67
> +    if (is<StylePendingImage>(m_image.get()))

Can we avoid the .get() here? An overload for RefPtr? Maybe that's overkill.

> Source/WebCore/css/CSSImageSetValue.cpp:193
> +    CachedResource* cachedResource = downcast<StyleCachedImageSet>(*m_imageSet).cachedImage();

cachedImage() returns a CachedImage*, and we store it in a CachedResource*, losing some type knowledge.
It doesn't actually matter in this case, but I'm commenting on it anyway because this is one reason I like auto.

[Chris Dumez]

Comment on attachment 240027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240027&action=review

>> Source/WebCore/css/CSSCursorImageValue.cpp:67
>> +    if (is<StylePendingImage>(m_image.get()))
> 
> Can we avoid the .get() here? An overload for RefPtr? Maybe that's overkill.

It is actually on my TODO list. There are actually not that many call sites that would benefit from it so it is not very high priority. Would still be nice to have though.

>> Source/WebCore/css/CSSImageSetValue.cpp:193
>> +    CachedResource* cachedResource = downcast<StyleCachedImageSet>(*m_imageSet).cachedImage();
> 
> cachedImage() returns a CachedImage*, and we store it in a CachedResource*, losing some type knowledge.
> It doesn't actually matter in this case, but I'm commenting on it anyway because this is one reason I like auto.

Ok, I will use tighter typing. (not a big fan of auto here because the type is not obvious but I understand it would help avoid this kind of loose typing mistakes).

[Chris Dumez]

Created attachment 240033 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 240033 [details]
Patch

Clearing flags on attachment: 240033

Committed r174836: <http://trac.webkit.org/changeset/174836>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.