Bug 131825 – [New Multicolumn] Enable new multi-column mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Jon Lee]

Enable new multi-column mode

<rdar://problem/16615061>

[Dave Hyatt]

These are the remaining three bugs that look like they really need a code fix:

https://bugs.webkit.org/show_bug.cgi?id=131805
https://bugs.webkit.org/show_bug.cgi?id=131808
https://bugs.webkit.org/show_bug.cgi?id=131809

This one makes me nervous, but I'm going to hope it's not an iBooks issue:

https://bugs.webkit.org/show_bug.cgi?id=131233

[Dave Hyatt]

https://bugs.webkit.org/show_bug.cgi?id=132071 is a blocker for turning new columns on. Was exposed after implementing nested columns support.

[Dave Hyatt]

Found a few more failures now that all the noise from the mock scrollbar bug is out of the way:

https://bugs.webkit.org/show_bug.cgi?id=132078
https://bugs.webkit.org/show_bug.cgi?id=132080
https://bugs.webkit.org/show_bug.cgi?id=132081

[Dave Hyatt]

Created attachment 230211 [details]
Patch

[Tim Horton]

Comment on attachment 230211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230211&action=review

> Source/WebKit/mac/WebView/WebPreferences.mm:520
> +        [NSNumber numberWithBool:YES],   WebKitRegionBasedColumnsEnabledKey,

indentation

[Build Bot]

Comment on attachment 230211 [details]
Patch

Attachment 230211 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4504061487349760

New failing tests:
fast/borders/border-antialiasing.html
compositing/columns/untransformed-composited-in-paginated.html
compositing/columns/hittest-composited-in-paginated.html
compositing/geometry/composited-in-columns.html
compositing/columns/composited-nested-columns.html
compositing/columns/clipped-in-paginated.html
css3/unicode-bidi-isolate-basic.html
compositing/columns/composited-columns.html
compositing/columns/composited-lr-paginated-repaint.html
fast/block/float/float-not-removed-from-next-sibling4.html
compositing/columns/rotated-in-paginated.html
compositing/columns/composited-columns-vertical-rl.html
compositing/columns/ancestor-clipped-in-paginated.html
fast/line-grid/line-grid-inside-columns.html
compositing/columns/composited-in-paginated.html
fast/overflow/paged-x-div-with-column-gap.html
compositing/columns/composited-in-paginated-writing-mode-rl.html
fast/overflow/paged-x-with-column-gap.html
fast/line-grid/line-grid-into-columns.html
fast/dom/Element/getBoundingClientRect.html
fast/forms/number/number-spinbutton-in-multi-column.html
fast/events/document-elementFromPoint.html
fast/forms/range/slider-in-multi-column.html
fast/overflow/paged-x-div.html
fast/forms/select/listbox-in-multi-column.html
compositing/columns/composited-in-paginated-rl.html
fast/multicol/shrink-to-column-height-for-pagination.html
fast/overflow/paged-x-on-root.html
fast/events/offsetX-offsetY.html

[Build Bot]

Created attachment 230220 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 230211 [details]
Patch

Attachment 230211 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5770698882547712

New failing tests:
fast/borders/border-antialiasing.html
compositing/columns/untransformed-composited-in-paginated.html
compositing/columns/hittest-composited-in-paginated.html
compositing/geometry/composited-in-columns.html
compositing/columns/composited-nested-columns.html
compositing/columns/clipped-in-paginated.html
css3/unicode-bidi-isolate-basic.html
compositing/columns/composited-columns.html
fast/overflow/paged-y-div.html
fast/block/float/float-not-removed-from-next-sibling4.html
compositing/columns/rotated-in-paginated.html
compositing/columns/composited-columns-vertical-rl.html
compositing/columns/ancestor-clipped-in-paginated.html
fast/line-grid/line-grid-inside-columns.html
compositing/columns/composited-in-paginated.html
fast/overflow/paged-x-div-with-column-gap.html
compositing/columns/composited-in-paginated-writing-mode-rl.html
fast/overflow/paged-x-on-root.html
fast/line-grid/line-grid-into-columns.html
fast/overflow/paged-y-on-root.html
fast/dom/Element/getBoundingClientRect.html
fast/forms/number/number-spinbutton-in-multi-column.html
fast/events/document-elementFromPoint.html
fast/forms/range/slider-in-multi-column.html
fast/overflow/paged-x-div.html
fast/forms/select/listbox-in-multi-column.html
compositing/columns/composited-in-paginated-rl.html
fast/overflow/paged-x-with-column-gap.html
fast/events/offsetX-offsetY.html

[Build Bot]

Created attachment 230227 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Dave Hyatt]

https://bugs.webkit.org/show_bug.cgi?id=132284 is a new blocker for the fast/forms control tests (which are genuinely failing).

[Dave Hyatt]

Another blocker (the elementFromPoint test) that might be the same bug as 132284.

https://bugs.webkit.org/show_bug.cgi?id=132285

[Dave Hyatt]

https://bugs.webkit.org/show_bug.cgi?id=132298 covers compositing layout tests that use RenderView's pagination mode failing.

[Dave Hyatt]

https://bugs.webkit.org/show_bug.cgi?id=132299 covers the nested columns compositing test failing.

[Dave Hyatt]

So basically four issues now that coverage has expanded to all layout tests (wish I had known about the compositing/columns directory ugh).

(1) All the compositing tests involving pagination on the RenderView fail.
(2) Compositing on nested columns fails.
(3) Hitting an assert related to compositing in RenderGeometryMap for columns cases.
(4) event.offsetX/event.offsetY don't work (mapAbsoluteToLocal isn't patched for new columns).

[Dave Hyatt]

Down to just the assert in the geometry map.

[Dave Hyatt]

Glitch with the fast/events tests still. They are off by the border of the multicolumn block. Should be easy to fix.

[Dave Hyatt]

https://bugs.webkit.org/show_bug.cgi?id=132383 is the blocker for the little offset glitch.

[Dave Hyatt]

https://bugs.webkit.org/show_bug.cgi?id=132392 is cropping up now. Not sure why it didn't show up before.

[Dave Hyatt]

Patch has been posted for it. Just waiting for someone to review it.

[Dave Hyatt]

Created attachment 230523 [details]
Patch

[Dave Hyatt]

Landed in r168046.

[Myles C. Maxfield]

Looks like this broke an API test: WebKit2.ResizeReversePaginatedWebView
http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/4324/steps/run-api-tests/logs/stdio

[Jon Lee]

unless the patch for this is being rolled out, subsequent issues should be tracked in other bugs. back to resolved.